-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency check: syntax and morphology #15
Comments
We can also use the @rule attributes to identify possible discrepancies with the morphology. |
Note that the categories used in the Westminster Hebrew Syntax are divided up differently than the Westminster Hebrew Morph. If you look at A Reference Guide to the Westminster Hebrew Morphology Database Document Release 4.20 (which is the version the Westminster Hebrew Syntax was built upon), there are only six categories: particle, pronoun, noun, adjective or numeral, verb, and suffixes. Definite article, object marker, conjunction, adverb, interjection, preposition, and relative particles belong within the category of particle. In the trees, these types have been separated out. Likewise, numerals have been separated out from adjectives. These differences account for the trees having 14 Cat vs. 6 categories in the Westminster morph originally. Here's a list of the 14 Cat in the trees & how they correspond to the OSHB morph categories: Be sure to look at my comments in https://github.com/Clear-Bible/macula-hebrew/tree/main/doc about the kind of systematic & frequent inconsistencies & mismatches I initially expect to see. |
See here for a more insightful (but less readable) table. The index column consists of the OSHB "pos" and "type" attributed, joined by "_". It seems that there are a lot of exceptions and mismatches. Only "x" and "suffix" match perfectly. Would it help if I:
|
Nice - this works great for part of speech. We will also need this kind of
display for other attributes shown in m elements (gender, number, state,
etc.)
And a way to drill down to instances.
Randall may have other ideas ...
Jonathan
…On Tue, Apr 5, 2022 at 6:31 AM klosoter ***@***.***> wrote:
Just checking, these are the mismatches/inconsistencies you are looking
for?
[image: Screenshot 2022-04-05 at 12 27 30]
<https://user-images.githubusercontent.com/61023061/161735160-7b37e9ee-5460-42af-a82d-b5944b648370.png>
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANPTPMQPGLDEVS7HE7D4RTVDQJBZANCNFSM5SLDGONA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Also helpful.
We should talk with Randall about workflows for using this kind of display
to correct errors and to decide which differences are just fine. We want
to make sure we have tooling to do whatever curation is needed efficiently.
Jonathan
…On Tue, Apr 5, 2022 at 8:33 AM klosoter ***@***.***> wrote:
See here for a more insightful (but less readable) table. The index column
consists of the OSHB "pos" and "type" attributed, joined by "_". It seems
that there are a lot of exceptions and mismatches. Only "x" and "suffix"
match perfectly.
Would it help if I:
- created a list of word ids for each combination of OSHB & Trees?
- find a way to categorize them further (using "rule", perhaps?)
cross_mapping.xlsx
<https://github.com/Clear-Bible/macula-hebrew/files/8418058/cross_mapping.xlsx>
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANPTPPER5OHBAVVU3NXWQ3VDQXJNANCNFSM5SLDGONA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Both of these are useful. Thank you, @klosoter. I agree with Jonathan's comments above. The volume of mismatches is higher than I'd like, but most of them don't surprise me at first glance. We'll want to curate these efficiently. |
I categorized them further using the "Rule" attribute of the first parent node. Now, the differences are neatly categorized. Most combinations of "pos_rule_type" match exactly ONE "Cat". At first glance, the differences seem more logical now. See attached. |
I've also put all mismatches in an XML file. They are structured like this: Cat --> oshb pos --> oshb type --> Tree Node --> oshb m element (or c in case of compounds)
Does something like this help drill down to instances? The XML file is too large to attach here, but you get the idea. |
The other features, such as number, gender, and person, are not present in the current trees. They are in the trees-groves-full under /trees-oshb but I can't seem to figure out an easy way to map these two trees to each other. The Is there an easy way to map the full attributes to the OSHB attributes that I overlooked? |
I think we need the mapping between Groves morphIds and our own added to the mapping file to do this comparison. |
I've created new mappings, which can be found in The new mappings can now be used to compare the grammatical categories between the Full Trees and OSHB. |
This is more of an epic than an individual issue.
When merging existing syntax trees with morphology, we have probably created instances where the morphological interpretation does not agree with the syntactic interpretation. We need to do a survey of instances where the OSHB morphological interpretation disagrees with the interpretation used to build the original Groves trees by comparing the two morphologies. Most of these differences will probably fall into categories that we can enumerate. This will include both differences in interpretation and clear bugs.
This task involves:
The text was updated successfully, but these errors were encountered: