Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: processed chrome ver with env subst #72

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

ryanbourdais
Copy link
Contributor

@ryanbourdais ryanbourdais commented Jun 21, 2023

This PR processes the chrome-version parameter using env subst, and should resolve and close #70

@ryanbourdais ryanbourdais requested a review from a team as a code owner June 21, 2023 19:25
@ryanbourdais ryanbourdais force-pushed the fix--chrome-version-env-vars branch from ff0d2db to 9b50f6c Compare June 26, 2023 17:09
@ryanbourdais
Copy link
Contributor Author

ryanbourdais commented Jun 26, 2023

Beta chrome driver tests are still failing as versions 115 and above 404 because there is no release for the beta, dev, or canary versions as of yet, also changed confirmations for chrome installs in install-chrome.sh as newer versions of chrome tack a "-1" at the end of the version and this causes the grep $VERSION command to fail when google-chrome-stable --version command is run.

@marboledacci marboledacci merged commit b545aa5 into main Nov 28, 2024
2 checks passed
@marboledacci marboledacci deleted the fix--chrome-version-env-vars branch November 28, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set chrome-version to an env variable in 1.4.1
2 participants