Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlc opens new window, rather than embedding when run under wayland #320

Open
leon-erd opened this issue Jun 12, 2024 · 3 comments
Open

vlc opens new window, rather than embedding when run under wayland #320

leon-erd opened this issue Jun 12, 2024 · 3 comments
Labels
enhancement external dependency Progress on this issue is blocked by a bug or lacking feature in software on which we depend

Comments

@leon-erd
Copy link

Describe the bug
When running pympress under wayland (e.g. in Hyprland) vlc opens videos in a new window instead of embedding. Does work as expected when running under xwayland with: GDK_BACKEND=x11 pympress test.pdf (see #60 (comment)). Would be nice to see full wayland support as more and more distros are shipping wayland by default now. If I hadn't stumbled across the comment in the closed issue I would have thought pympress was broken. I guess more users will run into this issue.

To Reproduce
Steps to reproduce the behavior:

  1. Create test.pdf in beamer / pdflatex that includes .mp4 video
  2. Run pympress test.pdf
  3. Click on placeholder for embedded video
  4. -> black screen in presentation, new window with video opens
  5. When running GDK_BACKEND=x11 pympress test.pdf everything works as expected

Environment (please complete the following information):

  • OS: Linux 6.9.3, NixOS
  • Python version: 3.11.9
  • Pympress version: 1.8.5
  • Installation method: nix package manager
@Cimbali
Copy link
Owner

Cimbali commented Jun 12, 2024

I don’t know if vlc supports embedding with wayland. Why not use gstreamer for video support?

(I don’t know off the top of my head which is default anymore, but I thought vlc was default only on Windows)

@leon-erd
Copy link
Author

I just tried on arch and there it works with gstreamer.
Found out that gstreamer playback is not supported by the current nixos downstream package but after a few tries I got it working. So I will make a PR in nixpkgs to fix the gstreamer support.

I can confirm that on wayland video playback works as expected with gstreamer but doesn't with vlc. Does that mean its an upstream issue of vlc?

@Cimbali
Copy link
Owner

Cimbali commented Jun 13, 2024

Embedding in wayland is just not supported yet: https://code.videolan.org/videolan/vlc/-/issues/16106

There’s no activity on that issue in the last 4 years and I don’t know where the mentioned blocking get_window is tracked.

@Cimbali Cimbali added enhancement external dependency Progress on this issue is blocked by a bug or lacking feature in software on which we depend labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement external dependency Progress on this issue is blocked by a bug or lacking feature in software on which we depend
Projects
None yet
Development

No branches or pull requests

2 participants