Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-setup): add current user to the DOCKER group #944

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(docker-setup): add current user to the DOCKER group #944

wants to merge 3 commits into from

Conversation

dhruvmistry2000
Copy link
Contributor

@dhruvmistry2000 dhruvmistry2000 commented Nov 12, 2024 •
edited by adamperkowski
Loading

When i used the docker setup in LINUTIL it didn't add the user to the docker group so this is the edited file

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@dhruvmistry2000
Adding current user to DOCKER group
aa392ab 
When i used the docker setup in LINUTIL it didn't add the user to the docker group so this is the edited file
@adamperkowski adamperkowski changed the title Adding current user to DOCKER group fix(docker-setup): add current user to the DOCKER group Nov 13, 2024
@adamperkowski adamperkowski added the bug Something isn't working label Nov 13, 2024
@dhruvmistry2000
Copy link
Contributor Author

Done

@adamperkowski @jeevithakannan2
use newgrp
e3397f8 
Co-authored-by: Jeevitha Kannan K S <[email protected]>
@dhruvmistry2000
Copy link
Contributor Author

Is there any problem ??

afonsofrancof
afonsofrancof approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@afonsofrancof afonsofrancof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeevithakannan2 jeevithakannan2 jeevithakannan2 approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

@afonsofrancof afonsofrancof afonsofrancof approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhruvmistry2000 @afonsofrancof @adamperkowski @jeevithakannan2