Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(installer, updater): formatting & small fixes #956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refact(installer, updater): formatting & small fixes #956

wants to merge 1 commit into from

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • Bug fix
  • Refactoring

Description

Installer -> Remove unreachable pacman case. dnf requires rustup-init before using rustup-init. Source .cargo/env after the installation of rustup.

Updater -> Formatting, Install rustup from dnf, change the wild case to use rustup.rs general installer from rust. Source the .cargo/env after the installation of rustup.

Testing

  • Tested on fedora 41 without issues.

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2
Refact and fix linutil-updated, installer
903cdc7 
Installer -> Remove unreachable pacman case. dnf requires rustup-init before using rustup-init. Source .cargo/env after the installation of rustup.

Updater -> Formatting, Add dnf installation, change the wild case to use
rustup.rs general installer from rust. Source the .cargo/env after the
installation of rustup.
@jeevithakannan2 jeevithakannan2 changed the title Linutil installer and updated refact Linutil installer and updater refact Nov 19, 2024
adamperkowski
adamperkowski requested changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant with rustup default stable

core/tabs/applications-setup/linutil-installer.sh Show resolved Hide resolved
core/tabs/applications-setup/linutil-installer.sh Show resolved Hide resolved
@adamperkowski adamperkowski changed the title Linutil installer and updater refact refact(installer, updater): formatting & small fixes Nov 19, 2024
@adamperkowski adamperkowski added refactor script Pull requests that update scripts labels Nov 19, 2024
@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Nov 19, 2024 •
edited
Loading

No not until you run rustup-init the rustup command will not be available in fedora and alpine.

That is what causes this #955

adamperkowski
adamperkowski approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay then. Couldn't find any official documentation on it, that's why I commented.

@jeevithakannan2 jeevithakannan2 mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
refactor script Pull requests that update scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing linutil on Fedora 41
2 participants
@jeevithakannan2 @adamperkowski