Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVR support #6461

Open
fabiopicchi opened this issue Jul 2, 2024 · 2 comments
Open

DVR support #6461

fabiopicchi opened this issue Jul 2, 2024 · 2 comments

Comments

@fabiopicchi
Copy link

Describe the problem to be solved

The client stack we use supports seeking HLS live streams (hlsjs + videojs). However, Peertube's client explicitly disables time controls in the GUI when broadcasting live.

Another issue is that the amount of ts files kept (necessary to control the buffer size) is not currently parametrizable and is a constant set here.

SEGMENTS_LIST_SIZE: 15, // 15 maximum segments in live playlist

I tried modifying these two files to see if I could enable rewinding the live stream all the way to the beginning and I was able to achieve some success, but the behavior is still a bit clunky.

  1. I turned on the liveui flag here:

  2. I disabled the smooth scrolling (since time calculation doesn't support live streams) here:

  3. I forced p2p to false here:

I was able to get a working UI but, for some reason, the seekbar isn't displayed as the live begins. I have to refresh the page for it to show itself. Also, the time being displayed in the control bar isn't nice, it would be cool if it displayed a negative time as in the seekbar and the "-:-:-" for the upper time limit isn't the best as well. I am opening this ticket to ask how to properly implement this feature. I would gladly contribute with its development if I can get some instructions.

Describe the solution you would like

I want to be able to seek a live stream, moving back and forth between what was already played and the live incoming bits of video.

@fabiopicchi
Copy link
Author

@Chocobozzz could you help me push forward this feature even if in a hacky way. The behaviour mostly works, but I can't understand why the seekbar isn't displayed as soon as the live starts. You have to refresh the page for it to show...

Do you know what might be toggling it off at the beginning?

@fabiopicchi
Copy link
Author

Not sure if it helps, but here are my changes:
fabiopicchi@51defab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants