Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fusion] Correctly handle null items in ResolveByKey #7217

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Jul 3, 2024

The fix and changed behavior can be seen in 0acf1f6.

Closes #7218

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (87f2bdb) to head (b5dbc49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7217      +/-   ##
==========================================
- Coverage   78.44%   78.20%   -0.25%     
==========================================
  Files        2384     2687     +303     
  Lines      117086   133274   +16188     
==========================================
+ Hits        91852   104231   +12379     
- Misses      25234    29043    +3809     
Flag Coverage Δ
unittests 78.20% <100.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 27bcec2 into main Jul 3, 2024
178 of 190 checks passed
@michaelstaib michaelstaib deleted the tte/fix-resolvebykey-null-item-handling branch July 3, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fusion] Null item in ResolveByKey leads to unexpected error
2 participants