Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): improve query name security_group_without_description #6867

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Feb 5, 2024

Proposed Changes

  • Update the query name for security_group_without_description, for some reason 'Rule' was included (which is a different rule, 68eb4bf3-f9bf-463d-b5cf-e029bb446d2e)

Resolves #7276

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added community Community contribution query New query feature labels Feb 5, 2024
@aristosvo aristosvo changed the title fix: improve query name for security group without description fix: improve query name for aws/security_group_without_description Feb 5, 2024
@github-actions github-actions bot added the aws PR related with AWS Cloud label Feb 5, 2024
@aristosvo aristosvo changed the title fix: improve query name for aws/security_group_without_description fix(aws/security_group_without_description): improve query name Feb 5, 2024
@aristosvo aristosvo changed the title fix(aws/security_group_without_description): improve query name fix(aws/security_group_without_description): improve query name Feb 5, 2024
@aristosvo aristosvo changed the title fix(aws/security_group_without_description): improve query name fix(query): improve query name security_group_without_description Feb 5, 2024
@github-actions github-actions bot removed the aws PR related with AWS Cloud label Feb 5, 2024
@aristosvo aristosvo force-pushed the fix/query-name-security-group branch from f8643d6 to 2b99694 Compare February 5, 2024 19:21
@aristosvo aristosvo requested a review from a team as a code owner October 9, 2024 11:27
Copy link
Contributor

@JulioSCX JulioSCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aristosvo, great catch! I've reviewed and approved your PR—thanks a lot for your contribution!

@JulioSCX JulioSCX merged commit 227c276 into Checkmarx:master Oct 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query(terraform): security_group_without_description, improve queryName
2 participants