Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for jsx files (AST-70294) #952

Closed
wants to merge 1 commit into from
Closed

Support for jsx files (AST-70294) #952

wants to merge 1 commit into from

Conversation

sarahCx
Copy link
Contributor

@sarahCx sarahCx commented Dec 3, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Added support for 'jsx' files in scans.

References

https://checkmarx.atlassian.net/browse/AST-70294

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team December 3, 2024 19:56
@github-actions github-actions bot added the bug Something isn't working label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Logo
Checkmarx One – Scan Summary & Detailsda5e4c12-3ba8-4362-a708-780ab9f94b3b

No New Or Fixed Issues Found

@@ -136,6 +136,7 @@ var BaseIncludeFilters = []string{
"*.cmp",
"Directory.Packages.props",
"*.rs",
"*.jsx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have tests for this area?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the test that you added in general for this area

@sarahCx sarahCx closed this Dec 4, 2024
@sarahCx sarahCx deleted the Bug/addJSXSupport branch December 4, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants