Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASCA Port Overwrite Issue in .checkmarx.yml (AST-75444) #946

Merged
merged 18 commits into from
Nov 24, 2024
Merged

Fix ASCA Port Overwrite Issue in .checkmarx.yml (AST-75444) #946

merged 18 commits into from
Nov 24, 2024

Conversation

AlvoBen
Copy link
Collaborator

@AlvoBen AlvoBen commented Nov 20, 2024 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Added a method that write a single value to .checkmarx.yml

References

https://checkmarx.atlassian.net/browse/AST-75444

Testing

Added unit tests

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@AlvoBen AlvoBen requested a review from OrShamirCM as a code owner November 20, 2024 14:54
@OrShamirCM OrShamirCM requested a review from a team November 20, 2024 14:54
@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 5b3adf96-c533-4e13-ac3f-ab81026d7b68

No New Or Fixed Issues Found

OrShamirCM
OrShamirCM previously approved these changes Nov 20, 2024
View reviewed changes
@AlvoBen AlvoBen changed the title Bug/benalvo/set asca port in config Fix ASCA Port Overwrite Issue in .checkmarx.yml (AST-75444) Nov 21, 2024
OrShamirCM
OrShamirCM previously approved these changes Nov 21, 2024
View reviewed changes
OrShamirCM
OrShamirCM previously approved these changes Nov 24, 2024
View reviewed changes
@AlvoBen AlvoBen merged commit 10947ef into main Nov 24, 2024
9 checks passed
@AlvoBen AlvoBen deleted the bug/benalvo/set-asca-port-in-config branch November 24, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrShamirCM OrShamirCM OrShamirCM approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvoBen @OrShamirCM @BenAlvo1