-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace certificates for pub keys #14
Comments
We pin to the public key, not the leaf cert, so as long as the key isn't regenerated it should work okay. I think the LE default is to renew just the cert and not regen the key but I could be mistaken. |
It doesn't seem so. I've checked one of oldest entries, Calyx, and it contains a full certificate (a CA signed public key) in the
To check it yourself you can run: |
Do you mean in ChatSecure code itself? That way you are right, it should work as long as the pub key isn't renewed. |
Ya in the code itself. The problem there is that the processing code only handles the full cert at the moment, so it is easier to just keep it as is for now. :) |
Most XMPP servers on the list are now using Let's Encrypt certificates, which have a short 90 days lifetime. This means that the certificate property will become quickly outdated. IMO it should be removed. Otherwise you would need a bot to continuously monitor all domains and update certificates.
The text was updated successfully, but these errors were encountered: