Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: use node v20 throughout monorepo #5730
chore!: use node v20 throughout monorepo #5730
Changes from all commits
4c1616b
a899503
6ce7718
9ff2e2a
1d5c3c1
c153a27
7b70892
84e44b8
9494c71
0c47758
8354bd4
b38bee6
d296b2f
e1f07be
d954b96
409d8ad
cfcc70e
cf9f1da
3f6dd77
f716f64
2e115d0
49df2c2
2925e87
0190311
7744f8f
3ae47c4
1887287
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wemeetagain I updated this to 20.x as well, not sure if it was intentionally not updated before but as we discussed that we want to advocate for using node 20 I think we should update it here as well.
Last reference to 18.x is in package.json but that might be to disruptive for users to update to 20.x, although we could ensure everyone is using node 20 this way
lodestar/package.json
Line 5 in 1887287
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: v20 is not yet LTS version until 2023-10-24, see nodejs-release-working-group for schedule
Check warning
Code scanning / CodeQL
Shell command built from environment values
Check warning
Code scanning / CodeQL
Shell command built from environment values
Check warning
Code scanning / CodeQL
Shell command built from environment values
Check warning
Code scanning / CodeQL
Shell command built from environment values