Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Components #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Docker Components #28

wants to merge 1 commit into from

Conversation

CedricAnover
Copy link
Owner

Description

Implementation for DockerCommandExecutor and other Marsh Docker Components.

TODO:

  • Add DockerCommandGrammar.
  • Update DockerCommandExecutor with DockerCommandGrammar as constructor argument.
  • Add DockerFactory.

closes #9

What kind of changes did you make?

  • Add new feature or enhancement (core or non-core components)?
  • Add or update extensions (non-core components)?
  • Refactor or optimize code?
  • Fix a bug?
  • Add or update the documentations?
  • Add or update the tests?

Checklist

  • This PR represents my original work and does not include plagiarized code.
  • I have read and adhered to the project’s CONTRIBUTING guidelines.
  • I have followed the project's coding style and guidelines.
  • Documentation has been updated to reflect changes (e.g., README, inline comments, etc.).
  • Related API documentation, if any, has been updated.
  • My code is self-documented with clear comments for complex areas.
  • Public methods and classes include appropriate docstrings.
  • Function names, variables, and class names are descriptive and adhere to naming conventions.
  • I understand that pull requests will not be merged if they do not pass the automated tests.
  • New functionality is covered by automated tests.
  • Code changes have been tested across relevant environments or configurations.
  • I have verified that the changes do not introduce any new vulnerabilities or security risks.

@CedricAnover CedricAnover added feature New feature or enhancement extension Extension from core labels Dec 27, 2024
@CedricAnover CedricAnover self-assigned this Dec 27, 2024
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
635 342 54% 0% 🟢

New Files

File Coverage Status
src/marsh/docker/docker_executor.py 0% 🟢
TOTAL 0% 🟢

Modified Files

File Coverage Status
src/marsh/core/executor.py 77% 🟢
src/marsh/docker/_init_.py 0% 🟢
TOTAL 38% 🟢

updated for commit: 3d4748d by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Extension from core feature New feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Docker Components
1 participant