Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indented heredoc injection editing fails #2894

Open
hurricup opened this issue Sep 3, 2024 · 0 comments
Open

Indented heredoc injection editing fails #2894

hurricup opened this issue Sep 3, 2024 · 0 comments
Labels
Bug Editor Injections
Milestone
2025.1

Comments

@hurricup
Copy link
Collaborator

hurricup commented Sep 3, 2024

  1. Create indented heredoc with html injection
  2. Use intention to edit html fragment
  3. try to type something

Exp: Changing text should be reflected in heredoc
Act: editor window closes immediatelly with an error
@hurricup hurricup added this to the 2024.2.2 milestone Sep 3, 2024
hurricup added a commit that referenced this issue Sep 14, 2024
@hurricup
#2894 Added test illustrating incorrect behavior
5c45aa7 
Editor is not closed but updated text is wrong
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 Do not update content if it didn't change
eab1cd3
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 Improved heredoc content update process
e9e5263 
- No fancy indentation adjustments.
- One line updates will work by themselves, because injection is already indented
- One line to multiline updates are now properly indented
- Added tests
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 moved to the platform changes handler
adbfd88
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 handled empty heredoc injection (need to adjust indentation for…
29f0e1f 
… the first element)
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 final fix
c9257b6
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 better test samples, better empty handling
8720773
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 two tests still failing
4762ed9
hurricup added a commit that referenced this issue Sep 15, 2024
@hurricup
#2894 final enter not working because it changes outside the smart range
e67e3ad
hurricup added a commit that referenced this issue Sep 23, 2024
@hurricup
#2894 do not inject into last newline
e8211ce
@hurricup hurricup modified the milestones: 2024.2.2, 2024.2.3 Sep 23, 2024
@hurricup hurricup modified the milestones: 2024.2.3, 2024.2.4 Oct 20, 2024
@hurricup hurricup modified the milestones: 2024.2.4, 2024.3.1 Nov 17, 2024
@hurricup hurricup modified the milestones: 2024.3.1, 2025.1 Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Editor Injections
Projects
None yet
Milestone
2025.1
Development

No branches or pull requests
1 participant
@hurricup