Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route bindings module is too coupled to the store utilities #187

Open
sgobotta opened this issue Oct 26, 2019 · 0 comments
Open

Route bindings module is too coupled to the store utilities #187

sgobotta opened this issue Oct 26, 2019 · 0 comments
Labels
enhancement New feature or request refactor Ch, ch, ch, ch, changes!

Comments

@sgobotta
Copy link
Member

Is your feature request related to a problem? Please describe.
Someday we'd like to separate small parts of the core code to their own package. I notice the @router/route.bindings module knows too much about the @store/utils module. I'm not sure if this represents a problem right now, but it's starting to ring a bell.

Describe the solution you'd like
We need an accurate and simple way for the Resource component to call the route bindings using imported utils, instead of the router knowing where those utils can be found.

Describe alternatives you've considered
I imagine Resource importing a set of store utils and passing them to the createRouteBindings. open to discussion.

@sgobotta sgobotta added enhancement New feature or request refactor Ch, ch, ch, ch, changes! labels Oct 26, 2019
@sgobotta sgobotta added this to To do in Current Tasks via automation Oct 26, 2019
@sgobotta sgobotta moved this from To do to Backlog in Current Tasks Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Ch, ch, ch, ch, changes!
Projects
Current Tasks
  
Backlog
Development

No branches or pull requests

1 participant