Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace server magazine services specific data generators with fake-data-generator #160

Open
5 tasks
sgobotta opened this issue Sep 30, 2019 · 2 comments
Open
5 tasks
Assignees
Labels
configuration Project's general configuration good first issue Good for newcomers Hacktoberfest (◡ ‿ ◡ ✿) 2019

Comments

@sgobotta
Copy link
Member

sgobotta commented Sep 30, 2019

In the utils server we are using too many custom functions for the magazines fake data. We could replace that using the fake-data-generator as a dev-dependency.

Current models: please respect the current type of each property

magazine: {
  id: Number, // faker random number
  name: String, // faker random words
  articles: Array, // Please delete this one
  issue: String, // faker random numbers with a '#' prefix
  publisher: String // faker random words
}

Checkpoints:

  • Run the e2e tests, they should pass.
  • Run the unit tests, they should pass.
  • Magazines service: Replace ipsum dependency with fake-data-generator. Replace the magazines array with a new fake-data-generator model of 40 items (don't worry about the articles array property in each magazine, we don't need it anymore)
  • Rerun e2e tests, they must pass.
  • Rerun unit tests, they must pass.
@sgobotta sgobotta added configuration Project's general configuration good first issue Good for newcomers Hacktoberfest (◡ ‿ ◡ ✿) 2019 labels Sep 30, 2019
@sgobotta sgobotta added this to To do in Current Tasks via automation Sep 30, 2019
@glmaljkovich
Copy link
Contributor

Dibs

@glmaljkovich glmaljkovich self-assigned this Sep 30, 2019
@glmaljkovich
Copy link
Contributor

I think to add the issue number using fake-data-generator we first need to add a prepend field type to that library

@sgobotta sgobotta moved this from To do to In progress in Current Tasks Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Project's general configuration good first issue Good for newcomers Hacktoberfest (◡ ‿ ◡ ✿) 2019
Projects
Current Tasks
  
In progress
Development

No branches or pull requests

2 participants