Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List e2e Tests: refactor navigation methods #114

Open
5 tasks
sgobotta opened this issue May 27, 2019 · 0 comments
Open
5 tasks

List e2e Tests: refactor navigation methods #114

sgobotta opened this issue May 27, 2019 · 0 comments
Labels
clean up Clean code good first issue Good for newcomers Hacktoberfest (◡ ‿ ◡ ✿) 2019 refactor Ch, ch, ch, ch, changes! test

Comments

@sgobotta
Copy link
Member

The navigateToNextPage, navigateToFirstPage seems to be repeated in every test for the List views.

My first thought is to refactor those 2 functions to the tests/e2e/lib/helpers.js directory.

  • Check if another module holds better the functions refactor
  • Refactor the articles List e2e test.
  • Refactor the magazines List e2e test
  • Refactor the authors List e2e test
  • Check all the tests pass
@sgobotta sgobotta added good first issue Good for newcomers refactor Ch, ch, ch, ch, changes! test clean up Clean code labels May 27, 2019
@sgobotta sgobotta added this to To do in Current Tasks Jun 10, 2019
@sgobotta sgobotta added the Hacktoberfest (◡ ‿ ◡ ✿) 2019 label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Clean code good first issue Good for newcomers Hacktoberfest (◡ ‿ ◡ ✿) 2019 refactor Ch, ch, ch, ch, changes! test
Projects
Current Tasks
  
To do
Development

No branches or pull requests

1 participant