Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace server article services specific data generators with fake-data-generator #100

Open
6 tasks
sgobotta opened this issue Mar 31, 2019 · 0 comments
Open
6 tasks

Replace server article services specific data generators with fake-data-generator #100

sgobotta opened this issue Mar 31, 2019 · 0 comments
Labels
configuration Project's general configuration good first issue Good for newcomers Hacktoberfest (◡ ‿ ◡ ✿) 2019
Projects
Current Tasks

Comments

@sgobotta
Copy link
Member

sgobotta commented Mar 31, 2019 •
edited
Loading

In the utils server we are using too many custom functions for the articles fake data. We could replace that using the fake-data-generator as a dev-dependency.

Current models: please respect the current type of each property

article: {
  id: Number, // eg: faker random number
  title: String, // eg: faker random words
  content: String, // eg: faker lorem text
  views: Number, // eg: randomNumberBetween or random
}

Checkpoints:

  • Run the e2e tests, they should pass.
  • Run the unit tests, they should pass.
  • Articles service: Replace ipsum dependency with fake-data-generator. Replace the magazines array with a new fake-data-generator model of 40 items
  • Remove bavaria-ipsum dependency from the pcakge.json in utils/server-test/
  • Rerun e2e tests, they must pass.
  • Rerun unit tests, they must pass.
@sgobotta sgobotta changed the title Replace specific data generators with fake-data-generator Replace server services specific data generators with fake-data-generator Mar 31, 2019
@sgobotta sgobotta added good first issue Good for newcomers demo app demo app improvements labels Mar 31, 2019
@sgobotta sgobotta added this to To do in Current Tasks Mar 31, 2019
@sgobotta sgobotta added configuration Project's general configuration Hacktoberfest (◡ ‿ ◡ ✿) 2019 and removed demo app demo app improvements labels Sep 30, 2019
@sgobotta sgobotta changed the title Replace server services specific data generators with fake-data-generator Replace server articles services specific data generators with fake-data-generator Sep 30, 2019
@sgobotta sgobotta changed the title Replace server articles services specific data generators with fake-data-generator Replace server article services specific data generators with fake-data-generator Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
configuration Project's general configuration good first issue Good for newcomers Hacktoberfest (◡ ‿ ◡ ✿) 2019
Projects
Current Tasks
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgobotta