Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a new Tab which can list the graphs having Nan #5357

Open
gj00354347 opened this issue Jun 8, 2023 · 18 comments
Open

create a new Tab which can list the graphs having Nan #5357

gj00354347 opened this issue Jun 8, 2023 · 18 comments
Assignees
Labels
enhancement General tag for an enhancement

Comments

@gj00354347
Copy link

Feature Request

Hi Team ,

we are using cacti 1.2.18 in our prod Env which is used for monitoring around 5K devices along with their 500K graphs . Many times the Client complains about non-working graphs , I mean the graphs which are showing nan , due to several reasons like interface exist no more , or snmp timeout issues or the values are beyond the specified limit .

so can we have such feature like a Tab called , "NAN Graphs" and in that Tab we can have a device filter and a date or duration Filter .and using that Tab we can come to know about the Graphs having Nan .

or can we have some efficient script which takes less I/O , less ram , and return the list of non-working graphs having nan , which we can run weekly or monthly and find the list of graphs having nan.

Is your feature request related to a problem? Please describe

A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've
considered.

Additional context

Add any other context or screenshots about the feature request here.

@gj00354347 gj00354347 added the enhancement General tag for an enhancement label Jun 8, 2023
@gj00354347 gj00354347 changed the title create a new Tab which can list the graphs having Nan for a specified duration used in the filter of that Tab create a new Tab which can list the graphs having Nan Jun 8, 2023
@xmacan
Copy link
Member

xmacan commented Jun 8, 2023

Please have a look at #4943

@anarkia1976
Copy link

Please have a look at #4943

hi @xmacan,
Good, but how we can find graphs with NAN values?
could you direct on how to identify by red check?
thanks a lot.

@gj00354347
Copy link
Author

@xmacan Hey many thanks ); for pointing me to this .

just a few questions , As I am on 1.2.18 and do not know the GUI of 1.2.23 where this feature is available .
so my question is in the ticket , I see stale rrd checks , there I see 3 columns Date , DS and Message , so does the message field contain the Graph name that's in Cacti GUI or is there any other column ??

because Knowing DS is good but we need to map those DSes with Graph Name , so is that available ?? and can we put some kind of alerting in this through Thold so that we can generate ticket on this and can start working on this rather than manually checking the page every 2 or 3 weeks.

@netniV
Copy link
Member

netniV commented Jun 8, 2023

If you look at the 1.2.x code, take a look at the clog_regex_xxx functions, these convert various IDs to names.

If you look at the 1.3.x code, this has been moved from clog to text_regex_xxx to make them more generally available.

@gj00354347
Copy link
Author

@netniV Hi Vinten ,

thanks . so is that clog_regex_xx feature available in GUI as well or I will have to make use of it through back end CLI ??
if this is available in GUI of cacti , it will make our life much easier .

@xmacan
Copy link
Member

xmacan commented Jun 9, 2023

@xmacan Hey many thanks ); for pointing me to this .

just a few questions , As I am on 1.2.18 and do not know the GUI of 1.2.23 where this feature is available . so my question is in the ticket , I see stale rrd checks , there I see 3 columns Date , DS and Message , so does the message field contain the Graph name that's in Cacti GUI or is there any other column ??

because Knowing DS is good but we need to map those DSes with Graph Name , so is that available ?? and can we put some kind of alerting in this through Thold so that we can generate ticket on this and can start working on this rather than manually checking the page every 2 or 3 weeks.

I will look at it. I think that add graph names is small change

@gj00354347
Copy link
Author

Many Thanks @xmacan , eagerly awaiting this feature in cacti 1.2.25 );

@netniV
Copy link
Member

netniV commented Jun 9, 2023

The regex code is already present in the code, but may not be utilised in the location you want. With 1.3.x, the code was moved and made to work with and without providing links to the HTML pages to manage them, so any changes in 1.2.x will require porting manually to 1.3.x

@TheWitness
Copy link
Member

We have to be careful with Regex due to a recent CVE. We've put some mitigation in place. Hopefully it's good enough.

@TheWitness
Copy link
Member

How many NaN's means NaN? Anyway, I think it's almost there already from my perspective.

@xmacan xmacan self-assigned this Jun 11, 2023
@xmacan
Copy link
Member

xmacan commented Jun 12, 2023

Screenshot 2023-06-12 at 17-18-17 Console Utilities RRD Check

@gj00354347 , @anarkia1976 - something like this?

@anarkia1976
Copy link

Screenshot 2023-06-12 at 17-18-17 Console Utilities RRD Check

@gj00354347 , @anarkia1976 - something like this?

good very good, pefect.

@netniV
Copy link
Member

netniV commented Jun 12, 2023

Just remember, if this is a new feature, it's a 1.3.x implementation. :)

@xmacan
Copy link
Member

xmacan commented Jun 12, 2023

damn, I have prepared it for 1.2.x in last few minutes

@gj00354347
Copy link
Author

Screenshot 2023-06-12 at 17-18-17 Console Utilities RRD Check

@gj00354347 , @anarkia1976 - something like this?

Yes very much like this , where we have filter like time span like nan for 2 hours or nan for 2 days or nan for 2 months .

@xmacan
Copy link
Member

xmacan commented Jun 12, 2023

I think about email notification. RRDchecker is started periodically. I would like to send email when periodical check found any issue.

@gj00354347
Copy link
Author

I think about email notification. RRDchecker is started periodically. I would like to send email when periodical check found any issue.

Yes very much ok approach , like run that check every week or every 2 weeks . But one thing we can improve here like in addition to sending emails , can we send log like thold module which sends the breach log to /var/log/err and a ticket is generated in ticketing tool . Here we can set a filter like if x, y or x device is having problem then send the msg to err log or if the No of graphs having nan is more than 10 or 15 then send a consolidated log which lists the problematic interfaces or unpopulated interfaces in err log and then ticketing tool will come in picture.

@xmacan
Copy link
Member

xmacan commented Jun 22, 2023

The result = I will prepare it for 1.3.x cccording to the notes and requirements in #5373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

5 participants