Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Throw error when RT feed has vehicles/tripUpdates for trips that aren't active in static #408

Open
barbeau opened this issue Jan 31, 2022 · 1 comment
Labels
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Jan 31, 2022

Summary:

When handling temporary service a common error is to accidentally have mismatches between the static and RT so that the RT feed has trip IDs that aren't shown as active in the static data. For example, on a Sunday the RT feed might have vehicle or TripUpdates for tripID = 4, but in the static data it shows trip_id = 4 as not running on a Sunday - in this case, it should be an error.

See https://groups.google.com/g/onebusaway-developers/c/WhgMbZ66rbY for further discussion.

Steps to reproduce:

Run a GTFS and GTFS Realtime feed through the validator when the RT feed is running on a Sunday, with links to static GTFS data that contains these trip IDs but the static GTFS data says that trip doesn't operate on a Sunday.

Expected behavior:

Validator should throw an error in this case

Observed behavior:

No errors are logged.

@barbeau barbeau added this to the v1.0 milestone Jan 31, 2022
@barbeau
Copy link
Member Author

barbeau commented Jan 31, 2022

Note that this is effectively an inverse of proposed new rule #390 - that rule would detect when service is scheduled but no vehicle/trip update is serving it.

@barbeau barbeau changed the title Throw error when currently active RT vehicles/tripUpdates are for trips that aren't active in static Throw error when RT feed has vehicles/tripUpdates for trips that aren't active in static Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant