Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Performance: Use get() and put() instead of computeIfAbsent() for HashMaps #392

Open
barbeau opened this issue Dec 9, 2020 · 0 comments
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Dec 9, 2020

Summary:

Benchmarks when working on gtfs-validator show that computeIfAbsent() is about 20% more expensive than calling get() and put().:
https://github.com/MobilityData/gtfs-validator/pull/546/files#diff-ab042c46ddc495ec40e8c9a80fdd5ea27dfbac6582dc76a973e523dd34c7b0f9R57

We should optimize the RT validator as necessary.

Steps to reproduce:

Run the validator

Expected behavior:

Have ideal performance when adding to HashMap

Observed behavior:

Benchmarks in context of static GTFS show we're using a slower method

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant