Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve welcome message cooldown criteria #311

Open
CarrotManMatt opened this issue Aug 16, 2024 · 3 comments
Open

Improve welcome message cooldown criteria #311

CarrotManMatt opened this issue Aug 16, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers high priority Needs focus/attention as soon as possible

Comments

@CarrotManMatt
Copy link
Member

Currently a welcome message will not be sent after induction if there has been a previous welcome message sent within the past 7 messages of the channel. This prevents frequent spam of welcome messages.

I suggest that the cooldown condition also includes a time based criteria. That is that the welcome message should be allowed to be sent if the previous condition was not met, but it has been greater than a certain amount of cooldown time. So a new welcome message can be sent right after a previous welcome message, so long as enough time has passed since the first welcome message was sent.

Thoughts on whether to include this change would be appreciated.

@CarrotManMatt CarrotManMatt added enhancement New feature or request question Further information is requested labels Aug 16, 2024
@CarrotManMatt
Copy link
Member Author

A new idea I just came up with is to have a confirmation button. If the committee member chooses to induction not silently, and a message had already been sent recently they should be asked whether they wish to still send the welcome message or to switch to a silent induction to prevent clogging up the channel. This allows for overriding the cooldown or preventing mistakes if the committee member initially chose the wrong induction type.

@CarrotManMatt
Copy link
Member Author

The initially implemented cooldown criteria were removed in #313

@MattyTheHacker
Copy link
Member

yeah all this sounds good:

  • lower recent message count
  • add time based check
  • allow cmt to override

@CarrotManMatt CarrotManMatt added good first issue Good for newcomers high priority Needs focus/attention as soon as possible and removed question Further information is requested labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers high priority Needs focus/attention as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants