-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MessageSendForbidden error and handling #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach taken here, however have 2 main changes that need to be made (before I make comments on specific formatting changes).
-
The error capture decorators are used for any interactions that do not have exceptions captured by default (I.e. tasks & event listeners need exceptions capturing, whereas commands have exceptions captured by the
on_application_command_error
event listener). Therefore handling of capturing theMessageSendForbiddenError
should be performed by the decorators for the tasks & event listeners as it is now, but also is required within the command error handler.
TL;DR: handleMessageSendForbiddenError
withinon_application_command_error
event listener. -
The current error capture decorators use the
capture_error_and_close()
function. This should be refactored to determine whether TeX-Bot actually needs closing on a per-decorator basis. Thecapture_guild_does_not_exist_error
&capture_strike_tracking_error
decorators should close TeX-Bot, whereascapture_message_send_forbidden_error
decorator shouldn't.
…forbidden-when-sending-messages # Conflicts: # cogs/strike.py
not a clue how to do any of that 🫡 |
No description provided.