Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add react-i18next tag to Cards components and page #726

Open
1 task done
AdhamAH opened this issue Jun 1, 2020 · 7 comments · May be fixed by #733
Open
1 task done

[FEAT] Add react-i18next tag to Cards components and page #726

AdhamAH opened this issue Jun 1, 2020 · 7 comments · May be fixed by #733
Assignees
@abhishekkumar08
Labels
enhancement New feature or request Frontend Issues pertaining to the Front end team

Comments

@AdhamAH
Copy link
Member

AdhamAH commented Jun 1, 2020

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

Add <Trans/> tag with the related i18nKey in locales JSON files use the EN as it is the default

Motivation

Applying the translations

Possible Alternatives

no translations

Additional Context
@AdhamAH AdhamAH added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Frontend Issues pertaining to the Front end team labels Jun 1, 2020
@gdemu13
Copy link
Contributor

gdemu13 commented Jun 13, 2020

Hi @AdhamAH , I'll do this

@AdhamAH AdhamAH removed the good first issue Good for newcomers label Jun 13, 2020
@abhishekkumar08
Copy link

Is the issue resolved? If not I want to work on this.

@AdhamAH
Copy link
Member Author

AdhamAH commented Jul 31, 2020

I don't know if @gdemu13 is still working on it?
I think it has been for a while so wait a bit to see if @gdemu13 didn't answer then you can go ahead if you wish

@AdhamAH AdhamAH removed the help wanted Extra attention is needed label Jul 31, 2020
@gdemu13
Copy link
Contributor

gdemu13 commented Jul 31, 2020

hi @AdhamAH, sorry didn't have time time to work on this issue. I don't mind if @thedeveloperhere wants to do it.

@abhishekkumar08
Copy link

yeah okay. I would be pleased to do so. @AdhamAH @gdemu13

@AdhamAH AdhamAH assigned abhishekkumar08 and unassigned gdemu13 Jul 31, 2020
@abhishekkumar08
Copy link

I have edited the files in pages folder. But I cant git commit is there a new thing, kindly help me with this.

@KartikSoneji
Copy link

@thedeveloperhere
This article might be helpful: https://reflectoring.io/github-fork-and-pull/

@abhishekkumar08 abhishekkumar08 linked a pull request Aug 6, 2020 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhishekkumar08 abhishekkumar08

Labels
enhancement New feature or request Frontend Issues pertaining to the Front end team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added the trans tag with the required i18nKey abhishekkumar08/Corona-tracker
4 participants
@gdemu13 @KartikSoneji @AdhamAH @abhishekkumar08