-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration parameters set in multiple places #108
Comments
I will add some notes to this effect to the wiki once I get write access :) |
|
See also some of the notes here https://github.com/COSIMA/access-om3/wiki/NUOPC-driver |
EDIT: and is hardcoded in the cice nuopc driver: |
We seem to have:
in datm_in and drof_in ( and docn_in) |
Can we make a simple script to flag any instances like this in configurations? The script would serve to document these gotchas as we discover them, and at some point might even be something we'd want to add to CI. Could be handy as we develop new configs. |
Dougie suggested doing it in in payu (#109). I think "best practice" would be to update the cmeps drivers ... possibly more trouble than its worth. |
Yeah I think it makes sense in many cases. That way the checks will run automatically whenever someone runs the model (and could pick up local changes that are inconsistent). Also, the checks will be automatically run in the repro CI, which uses Payu (though we probably will want a workflow specifically running the checks) |
Hey - coming in with a bit less domain knowledge here - I'm doing up CI checks as part of configuration modification as part of ACCESS-NRI/model-config-tests#63:
|
One of the discoveries from #81 is that some IO parameters are set in
nuopc.runconfig
but also could be set inice_in
and its not clear which is used.I propose we delete the unused lines in either file. I think I have done this in
ice_in
through ACCESS-NRI/access-om3-configs#17 but there are lines to delete innuopc.runconfig
, including:ice_nx = 360
,ice_ny = 300
I suggest we take a conservative approach. Rather than audit every line, let delete the ones we know are not used and merge the change but leave this issue open. As more unused lines are discovered, we can make another change referencing this issue.
The text was updated successfully, but these errors were encountered: