Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely accept any SizedData where possible in ImageRaster and BintableColumns #22

Open
kabasset opened this issue Feb 4, 2022 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request related to an existing service question Further information is requested
Milestone

Comments

@kabasset
Copy link
Collaborator

kabasset commented Feb 4, 2022

Methods like:

void ImageRaster::readTo(TRaster& raster)
void BintableColumns::readTo(ColumnKey key, TColumn& column)

(should) only use TRaster/TColumn::value_type, raster/column.size() and raster/column.data() (to be checked) so that the declaration and doc could be changed to:

void ImageRaster::readTo(TContainer& container)
void BintableColumns::readTo(ColumnKey key, TContainer& container)

without even changing the definition!

This would explicitly allow bypassing Raster and Column, e.g.:

// Given: ImageRaster du
std::vector<float> raster(du.readSize());
du.readTo(raster);

// Given: BintableColumns du
std::vector<float> column(du.readRowCount());
du.readTo("NAME", column);
@kabasset kabasset added documentation Improvements or additions to documentation enhancement New feature or request related to an existing service question Further information is requested labels Feb 4, 2022
@kabasset kabasset added this to the 5.1 milestone Feb 4, 2022
@kabasset kabasset self-assigned this Feb 4, 2022
@kabasset kabasset modified the milestones: 5.3, 6.0 Jul 31, 2023
@kabasset
Copy link
Collaborator Author

Check after #32 is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request related to an existing service question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant