Fe

[eclare108213]

Dissolved and particulate iron seems to be labeled inconsistently in the code and also in the documentation. In some places it is fed, fep, others dFe, pFe. Can we make all of these references or labels or variable names consistent, or is there a real difference in them?

[njeffery]

@eclare108213 : The names are correct in the documentation, but yes, they could be changed in the code. fed and fep are the ocean source values. dFe and pFe are used more commonly throughout to refer to ice quantities. It's probably simplest to change fed to dfe and fep to pfe in the code and documentation.

[eclare108213]

I didn't realize that ocean and ice location was distinguishing them. Should we be more explicit about that, e.g. dFei and dFeo?

[njeffery]

The other tracers refer to their ocean values using three lower case letters (eg. nit or sil). So both fed or dfe is consistent if not particularly clear. The more I look at the code, the more I see examples of "Fed_ and Fep_" refering to related iron quantities in the ice.

[eclare108213]

@njeffery This is a very old issue in the Icepack repo -- was the naming convention made more consistent in the new BGC code?

[njeffery]

@hunke, Elizabeth ***@***.***>: This hasn't been updated. We still use both fed/fep and dfe/pfe. If you'd like to pick one, that's fine with me. Nicole

…

________________________________ From: Elizabeth Hunke ***@***.***> Sent: Tuesday, August 27, 2024 12:27 PM To: CICE-Consortium/Icepack ***@***.***> Cc: Jeffery, Nicole ***@***.***>; Mention ***@***.***> Subject: [EXTERNAL] Re: [CICE-Consortium/Icepack] Fe (#77) @njeffery<https://urldefense.com/v3/__https://github.com/njeffery__;!!Bt8fGhp8LhKGRg!CeqlSTObJ2fo7648Fv9A-4q-c7QLxSE89syIyTjhAaICrCT5mUA52chgS_t5kES7RPRJg3eo-EjZDFWBWnPi6odwBA$> This is a very old issue in the Icepack repo -- was the naming convention made more consistent in the new BGC code? — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/CICE-Consortium/Icepack/issues/77*issuecomment-2313239822__;Iw!!Bt8fGhp8LhKGRg!CeqlSTObJ2fo7648Fv9A-4q-c7QLxSE89syIyTjhAaICrCT5mUA52chgS_t5kES7RPRJg3eo-EjZDFWBWnNSUMjrSQ$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB6UV2WPVHHWF3NEFWTM23LZTTAK7AVCNFSM6AAAAABNGWHCXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGIZTSOBSGI__;!!Bt8fGhp8LhKGRg!CeqlSTObJ2fo7648Fv9A-4q-c7QLxSE89syIyTjhAaICrCT5mUA52chgS_t5kES7RPRJg3eo-EjZDFWBWnOdkINtiA$>. You are receiving this because you were mentioned.Message ID: ***@***.***>