Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestep documentation and implementation consistency #139

Open
apcraig opened this issue May 11, 2018 · 1 comment
Open

Timestep documentation and implementation consistency #139

apcraig opened this issue May 11, 2018 · 1 comment
Assignees

Comments

@apcraig
Copy link
Contributor

apcraig commented May 11, 2018

PR #83 was closed and still needs to be addressed. See initial discussion there. Basically, I this is a documentation issue, but maybe also an implementation issue. The last comment in the PR was

"Then it makes sense to make the code and the documentation consistent. We can certainly use dt_dyn in the documentation instead of dt, in reference to the dynamics. It's true that dt is used both as the thermodynamic time step and as a generic one. I'm open to creating an explicit dt_therm time step but also happy to stick with dt, since the way the code is written, the thermo step is the main one and others cycle around it."

@eclare108213
Copy link
Contributor

I recommend just documenting this more clearly, and later taking a look at the implementation as part of the time manager planning work for #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants