Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: enable system notifications #268

Open
anikachurilova opened this issue Nov 22, 2024 · 0 comments
Open

notifications: enable system notifications #268

anikachurilova opened this issue Nov 22, 2024 · 0 comments

Comments

@anikachurilova
Copy link
Contributor

anikachurilova commented Nov 22, 2024

We might want to have in the future that the system will send automatic e-mails.

To be able to do that, we would need to have EntityResolver and EntityProxy, that are being used to resolve the identity, to handle System user.

For example, CommunityInclusionAcceptNotificationBuilder is using these entity resolvers. For the System user, the ServiceResultResolver for users will picked up. As a result, resolver will try to read user with id "system" from UsersService, which will fail.

Possible solutions:

  1. Add a new resolver to NOTIFICATIONS_ENTITY_RESOLVERS that handles system user
  2. Handle system user here in the similar way to how it's done here
  3. Other ideas?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant