Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate record for DeterministicVariables #407

Open
damonbayer opened this issue Aug 22, 2024 · 1 comment
Open

Deprecate record for DeterministicVariables #407

damonbayer opened this issue Aug 22, 2024 · 1 comment
Assignees
Labels
clean up Good code that could be better

Comments

@damonbayer
Copy link
Collaborator

damonbayer commented Aug 22, 2024

Originally posted by @damonbayer in #402 (comment)

DeterministicVariables should not have a record argument. Instead, they should take an optional name argument. If a name is supplied, the variable should always be recorded. If the name is omitted, then the variable should not be recorded.

For "composite RandomVariables containing multiple sites, each site should have an optional name argument, which determines whether the site is recorded.

@damonbayer damonbayer changed the title Relationship between RandomVariable names and record Deprecate record for DeterministicVariables Aug 23, 2024
@damonbayer damonbayer added clean up Good code that could be better and removed discussion labels Aug 23, 2024
@damonbayer
Copy link
Collaborator Author

This should extend to TransformedRandomVariables. They can be optionally named, and the naming should influence whether or not the transformed version of the variable is recorded.

@damonbayer damonbayer added this to the S Sprint milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants