You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Initially, the Benchcab class was to be used to define the CLI. There are now quite a few additional functions and it starts to feel like it contains what we don't know what to do with. #291 is adding an extra function there.
I am also not keen on the functions that have arguments (self, config) because config is an attribute of self already. And when passed via argument, we pass the value of self._config. So it seems we are mixing 2 different designs/ideas.
@CABLE-LSM/admins what do you think?
The text was updated successfully, but these errors were encountered:
Initially, the Benchcab class was to be used to define the CLI. There are now quite a few additional functions and it starts to feel like it contains what we don't know what to do with. #291 is adding an extra function there.
I am also not keen on the functions that have arguments
(self, config)
becauseconfig
is an attribute ofself
already. And when passed via argument, we pass the value ofself._config
. So it seems we are mixing 2 different designs/ideas.@CABLE-LSM/admins what do you think?
The text was updated successfully, but these errors were encountered: