Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink what is included in the Benchcab class #297

Open
ccarouge opened this issue May 17, 2024 · 0 comments
Open

Rethink what is included in the Benchcab class #297

ccarouge opened this issue May 17, 2024 · 0 comments
Labels
question Further information is requested

Comments

@ccarouge
Copy link
Collaborator

Initially, the Benchcab class was to be used to define the CLI. There are now quite a few additional functions and it starts to feel like it contains what we don't know what to do with. #291 is adding an extra function there.

I am also not keen on the functions that have arguments (self, config) because config is an attribute of self already. And when passed via argument, we pass the value of self._config. So it seems we are mixing 2 different designs/ideas.

@CABLE-LSM/admins what do you think?

@ccarouge ccarouge added the question Further information is requested label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant