Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated integration tests #241

Open
abhaasgoyal opened this issue Jan 22, 2024 · 2 comments
Open

Add automated integration tests #241

abhaasgoyal opened this issue Jan 22, 2024 · 2 comments
Labels
enhancement New feature or request priority:low Low priority Issues that do not need to be addressed in the near future. testing Add unit/integration tests

Comments

@abhaasgoyal
Copy link

abhaasgoyal commented Jan 22, 2024

Currently, one needs to run the integration test manually before a PR is accepted:

https://github.com/CABLE-LSM/benchcab/blob/af43dad820811bc0b5e56161957ca374aeeb704e/benchcab/data/test/integration.sh

Considering that outputs of these are dependent on systems, it would be better to have a consistent source of running these tests, thus giving a higher degree of confidence, as well as self-documenting behaviour

@abhaasgoyal abhaasgoyal added the enhancement New feature or request label Jan 22, 2024
@abhaasgoyal abhaasgoyal changed the title Add integration tests in CI Add additional tests in CI Jan 22, 2024
@abhaasgoyal abhaasgoyal changed the title Add additional tests in CI Add additional tests in CI - Integration, Code Style Jan 23, 2024
@abhaasgoyal abhaasgoyal changed the title Add additional tests in CI - Integration, Code Style Add additional tests in CI - integration, code style Jan 23, 2024
@abhaasgoyal abhaasgoyal changed the title Add additional tests in CI - integration, code style Add integration tests in CI Jan 29, 2024
@abhaasgoyal abhaasgoyal changed the title Add integration tests in CI Add automated integration tests Feb 2, 2024
@abhaasgoyal
Copy link
Author

For now, we can have it as a server-side hook on push communicating with CI

@bschroeter
Copy link
Collaborator

@abhaasgoyal, it would be worth talking to the release team to check progress on a GitHub runner that executes on Gadi. Security policies would be the main roadblock here, as the integration tests need to run on the login/compute nodes.

@SeanBryan51 SeanBryan51 added the testing Add unit/integration tests label Apr 25, 2024
@ccarouge ccarouge added the priority:low Low priority Issues that do not need to be addressed in the near future. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority Issues that do not need to be addressed in the near future. testing Add unit/integration tests
Projects
None yet
Development

No branches or pull requests

4 participants