Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff and black to CI #226

Open
bschroeter opened this issue Dec 21, 2023 · 0 comments · May be fixed by #301
Open

Add ruff and black to CI #226

bschroeter opened this issue Dec 21, 2023 · 0 comments · May be fixed by #301
Labels
priority:medium Medium priority issues to become high priority issues after a release. testing Add unit/integration tests

Comments

@bschroeter
Copy link
Collaborator

We can add black and ruff to the CI pipeline for this project, triggering failed builds if changes fail to meet standards.

Commands returning non-zero exits statuses in a CI pipeline would be:

black --check .
ruff .

Both commands would fail a pipeline without altering files, although we could do that if we wanted.
@ccarouge ccarouge added testing Add unit/integration tests priority:medium Medium priority issues to become high priority issues after a release. labels May 2, 2024
@abhaasgoyal abhaasgoyal linked a pull request Jul 17, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:medium Medium priority issues to become high priority issues after a release. testing Add unit/integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add black and ruff to CI CABLE-LSM/benchcab
2 participants
@bschroeter @ccarouge