Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facilitate output of potential evaporation directly from the offline code base #335

Closed
har917 opened this issue Jul 4, 2024 · 4 comments · Fixed by #346
Closed

facilitate output of potential evaporation directly from the offline code base #335

har917 opened this issue Jul 4, 2024 · 4 comments · Fixed by #346
Assignees

Comments

@har917
Copy link
Collaborator

har917 commented Jul 4, 2024

There are many applications where direct knowledge of potential evaporation (and/or its relation to simulated evaporation or evapotranspiration) would be of interest. However this is not facilitated by CABLE despite the canopy%epot variable carrying this information. While an approximation of average potential evaporation could be estimated from other outputs, the nonlinearity in the equations implies that it would be better evaluated by CABLE's inbuilt time averaging.

Note that ssnow%potev in CABLE is more strictly the 'latent heat flux consistent with potential evaporation from the soil' not evaporation itself - i.e. units are currently W/m2 not mm of water/s - this may need to be handled within this issue.

@har917 har917 self-assigned this Jul 14, 2024
@har917
Copy link
Collaborator Author

har917 commented Jul 14, 2024

Process

  • follow the general structure to add an additional output to offline model under flag out%potevap (check there maybe an existing entry)
  • allocate output variable to canopy%potev / air%rlam / ssnow%cls (which is the conversion of the 'latent heat associated with potential evaporation to potential evaporation'

edit: canopy%potev doesn't exist. ssnow%potev refers only to evaporation from the soil. Instead this fix will use the existing CABLE diagnostic variable canopy%epot.

@har917
Copy link
Collaborator Author

har917 commented Jul 16, 2024

@ccarouge I may have been unlucky with exactly when you did a merge/update of MAIN - but benchcab seems to have failed for me.

I think the problem is that the cable.nml file that gets created is/was still back with 'check%range = .FALSE.' - with the net result that nothing runs (and the bitwise comparison fails) - see
cable.nml.txt

I also note that the site specific outputs seem to reference ERROR ../../src/nccmp_state.c:156 No such file or directory -e.g.
AU-ASM_2011-2017_OzFlux_Met_S0_R0_R1.txt indicating that something else is missing.

Any suggestions? Perhaps I need to do a fresh git clone but I did do a benchcab clean all.

@har917
Copy link
Collaborator Author

har917 commented Jul 16, 2024

I think the problem is that the cable.nml file that gets created is/was still back with 'check%range = .FALSE.'

I've checked - git status indicates that my local copy of benchcab is in sync with origin/main except for the config.yaml file, and the nml file attached is that created by benchcab (for AU-ASM). The out.txt file is giving the NAMELIST input error

@ccarouge
Copy link
Collaborator

@har917 I believe this is now solved or about to be solved from the issue on benchcab repository. We still need some changes to benchcab, spatial configurations and the benchcab documentation so it works for everyone but you should be good here.

ccarouge added a commit that referenced this issue Aug 6, 2024
#346)

# CABLE

Thank you for submitting a pull request to the CABLE Project.

## Description

This PR adds the potential evaporation diagnostic (`canopy%epot`) to
fluxes section of the cable output.
A minor correction to the diagnostic has also been applied - which could
lead to impacts in the coupled model (via `%wetfac_cs` and JULES
variable `resft`) - and the checks_ranges updated.

Fixes #335

## Type of change

Please delete options that are not relevant.

- [x] Bug fix
- [x] additional output

## Checklist

- [x] The new content is accessible and located in the appropriate
section.
- [ ] I have checked that links are valid and point to the intended
content.
- [ ] I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


<!-- readthedocs-preview cable start -->
----
📚 Documentation preview 📚:
https://cable--346.org.readthedocs.build/en/346/

<!-- readthedocs-preview cable end -->
har917 added a commit that referenced this issue Aug 7, 2024
# CABLE

## Description

This PR aims to achieve two tasks
- removing the hard-wired lake index from the offline code (including GW
module)
- maintaining lakes at saturation in offline model (soil-snow only)

Fixes #341
Addresses #347

## Type of change

- [x] Bug fix
- [x] Science advancement 

## Checklist

- [x] The new content is accessible and located in the appropriate
section.
- [ ] I have checked that links are valid and point to the intended
content.
- [ ] I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


<!-- readthedocs-preview cable start -->
----
📚 Documentation preview 📚:
https://cable--348.org.readthedocs.build/en/348/

<!-- readthedocs-preview cable end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants