-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination (suggestion) #15
Comments
This is a good suggestion. I think we need to consider implementing it. |
How might you implement this, with the owner's objective of keeping all cards loaded in the frontend itself, and not using a DB? |
Yes, we know that the owner won't use db for now. For performance we can consider virtualisation. We can keep data in list format. And render the next set of cards only when needed. Assume you are implementing search functionality, when you find a match then you can dynamically construct cards. |
Hello there! Would this increase the complexity of the project? Or, should we create a JSON file with a list of terms and automatically create cards in HTML? - Refer to Issue #7 |
I'm currently testing the Firebase database for the project, and will keep you updated. |
We can use markdown files :D |
Hey guys, regarding the usage of the DB can you look at my approach and give me your oppinion ? |
I submitted my PR regarding pagination. |
Just a heads up, any PR should wait until #38 is resolved. |
Can you guys have a peek at my PR. |
@Ibrahim-Faisal15, the issue with the switch to a content-driven framework has been resolved in ticket #28. Do not create a new ticket until the issue with the switch to a content-driven framework is resolved in ticket #38. |
Hey people! Is anyone working on the pagination support? I think it's high time we look into that side as we have around 254 cards in the DOM getting rendered. As the terms increase, the number of DOM elements that gets loading in the single go is going to get increased.
As @Buzzpy mentioned are we going towards firebase or should we try pagination in front end itself. I can do a POC if we are open to doing pagination on FE. |
The firebase idea was dismissed due to a few reasons, I'm sorry I forgot to update this 😄 I think we should try pagination in the frontend itself. Would love your support here, @Sudharshaun ! 🤍 |
I can pick this up @Sudharshaun @Buzzpy |
@bellodamilola & @Sudharshaun |
I've started working on this already. I'm creating a solution for both a pagination case and a lazy loading infinite scroll case. I'll spend more time on this during the weekend tho. @ManorSailor you can try any other alternative, and then we pick which is a better solution. What do you think? |
Sounds great. I am willing to go give this a try. I'll be going Astro only route ;) |
Hello there, @bellodamilola and @ManorSailor! (No rush, just checking in 🐳) |
@Buzzpy Hey! Sorry for no updates, I have been busy with work lately. Thus, I haven't had the time to work on it yet. I will work on it soon & open a PR :) |
If the number of cards increases no need to render all cards at once, instead you can only show few cards in view and remaining in filters, search, pagination.
The text was updated successfully, but these errors were encountered: