Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination (suggestion) #15

Open
ravi-teja-nani opened this issue Aug 14, 2024 · 19 comments · May be fixed by #144
Open

Pagination (suggestion) #15

ravi-teja-nani opened this issue Aug 14, 2024 · 19 comments · May be fixed by #144
Assignees
Labels
Enhancement 🚀 New feature or request

Comments

@ravi-teja-nani
Copy link

If the number of cards increases no need to render all cards at once, instead you can only show few cards in view and remaining in filters, search, pagination.

@Himanshuch8055
Copy link

This is a good suggestion. I think we need to consider implementing it.

@RayMathew
Copy link
Contributor

How might you implement this, with the owner's objective of keeping all cards loaded in the frontend itself, and not using a DB?

@ravi-teja-nani
Copy link
Author

ravi-teja-nani commented Aug 15, 2024

How might you implement this, with the owner's objective of keeping all cards loaded in the frontend itself, and not using a DB?

Yes, we know that the owner won't use db for now. For performance we can consider virtualisation. We can keep data in list format. And render the next set of cards only when needed.

Assume you are implementing search functionality, when you find a match then you can dynamically construct cards.

@Buzzpy
Copy link
Owner

Buzzpy commented Aug 15, 2024

Hello there!
Now that the user base is growing and this project needs to add more terms and concepts to the list, I think it'd be a good idea to switch to a database.

Would this increase the complexity of the project? Or, should we create a JSON file with a list of terms and automatically create cards in HTML? - Refer to Issue #7

@Buzzpy Buzzpy added the Enhancement 🚀 New feature or request label Aug 15, 2024
@Buzzpy
Copy link
Owner

Buzzpy commented Aug 15, 2024

I'm currently testing the Firebase database for the project, and will keep you updated.

@bartosz-skejcik
Copy link

How might you implement this, with the owner's objective of keeping all cards loaded in the frontend itself, and not using a DB?

We can use markdown files :D

@Rodelph
Copy link
Contributor

Rodelph commented Aug 15, 2024

Hey guys, regarding the usage of the DB can you look at my approach and give me your oppinion ?
#9 (comment)

@Ibrahim-Faisal15
Copy link
Contributor

I submitted my PR regarding pagination.

@RayMathew
Copy link
Contributor

Just a heads up, any PR should wait until #38 is resolved.

@Ibrahim-Faisal15
Copy link
Contributor

Can you guys have a peek at my PR.

@Himanshuch8055
Copy link

@Ibrahim-Faisal15, the issue with the switch to a content-driven framework has been resolved in ticket #28. Do not create a new ticket until the issue with the switch to a content-driven framework is resolved in ticket #38.

@Sudharshaun
Copy link
Contributor

Hey people! Is anyone working on the pagination support? I think it's high time we look into that side as we have around 254 cards in the DOM getting rendered. As the terms increase, the number of DOM elements that gets loading in the single go is going to get increased.

I'm currently testing the Firebase database for the project, and will keep you updated.

As @Buzzpy mentioned are we going towards firebase or should we try pagination in front end itself. I can do a POC if we are open to doing pagination on FE.

@Buzzpy
Copy link
Owner

Buzzpy commented Aug 19, 2024

The firebase idea was dismissed due to a few reasons, I'm sorry I forgot to update this 😄

I think we should try pagination in the frontend itself. Would love your support here, @Sudharshaun ! 🤍

@bellodamilola
Copy link
Contributor

I can pick this up @Sudharshaun @Buzzpy

@ManorSailor
Copy link
Contributor

@bellodamilola & @Sudharshaun
Are you guys working on it? I'd like to help too.

@bellodamilola
Copy link
Contributor

I've started working on this already. I'm creating a solution for both a pagination case and a lazy loading infinite scroll case. I'll spend more time on this during the weekend tho.

@ManorSailor you can try any other alternative, and then we pick which is a better solution. What do you think?

@ManorSailor
Copy link
Contributor

I've started working on this already. I'm creating a solution for both a pagination case and a lazy loading infinite scroll case. I'll spend more time on this during the weekend tho.

@ManorSailor you can try any other alternative, and then we pick which is a better solution. What do you think?

Sounds great. I am willing to go give this a try. I'll be going Astro only route ;)

@Buzzpy
Copy link
Owner

Buzzpy commented Sep 15, 2024

Hello there, @bellodamilola and @ManorSailor!
How's it going? Did you have time to try it out?

(No rush, just checking in 🐳)

@ManorSailor
Copy link
Contributor

@Buzzpy Hey! Sorry for no updates, I have been busy with work lately. Thus, I haven't had the time to work on it yet. I will work on it soon & open a PR :)

@ManorSailor ManorSailor linked a pull request Sep 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants