fix: reduce memory consumption (#78)

Fixes #74
BugSplat-Git · Oct 3, 2024 · ffcc77e · ffcc77e
1 parent a211f2b
commit ffcc77e
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/BugSplatDotNetStandard/Utils/ZipUtils.cs b/BugSplatDotNetStandard/Utils/ZipUtils.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.IO.Compression;
@@ -11,14 +12,21 @@ internal class InMemoryFile
 
         public static InMemoryFile FromFileInfo(FileInfo fileInfo)
         {
-            using (FileStream fileStream = new FileStream(fileInfo.FullName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-            using (MemoryStream memoryStream = new MemoryStream())
+            const int bufferSize = 81920; // 80 KB buffer
+            using (var fileStream = new FileStream(fileInfo.FullName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite, bufferSize))
             {
-                fileStream.CopyTo(memoryStream);
-                return new InMemoryFile()
+                var bytes = new byte[fileInfo.Length];
+                int bytesRead, totalBytesRead = 0;
+
+                while ((bytesRead = fileStream.Read(bytes, totalBytesRead, Math.Min(bufferSize, bytes.Length - totalBytesRead))) > 0)
+                {
+                    totalBytesRead += bytesRead;
+                }
+
+                return new InMemoryFile
                 {
                     FileName = fileInfo.Name,
-                    Content = memoryStream.ToArray()
+                    Content = bytes
                 };
             }
         }
@@ -30,7 +38,6 @@ internal interface IZipUtils
         FileInfo CreateZipFile(string zipFileFullName, IEnumerable<FileInfo> files);
         string CreateZipFileFullName(string inputFileName);
         Stream CreateZipFileStream(string zipFileFullName);
-
     }
 
     internal class ZipUtils : IZipUtils