From e909cdaa25e814df272bf0a8f7fdaaf244ef131c Mon Sep 17 00:00:00 2001 From: Dave Lockhart Date: Wed, 21 Jun 2023 15:04:44 -0400 Subject: [PATCH 1/7] fix: reduce Firefox's concurrency to 1 to avoid unreliable focus (#35) --- src/server/wtr-config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/server/wtr-config.js b/src/server/wtr-config.js index da5d5805..c08dc7fe 100644 --- a/src/server/wtr-config.js +++ b/src/server/wtr-config.js @@ -213,6 +213,7 @@ export class WTRConfig { if (!Array.isArray(browsers)) throw new TypeError('browsers must be an array'); return browsers.map((b) => playwrightLauncher({ + concurrency: b === 'firefox' ? 1 : undefined, // focus in Firefox unreliable if concurrency > 1 (https://github.com/modernweb-dev/web/issues/238) product: b, createBrowserContext: ({ browser }) => browser.newContext({ deviceScaleFactor: 2, reducedMotion: 'reduce' }) })); From ed5a6b5d2784b2e5c885af9128c72c7a00ad8db2 Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Wed, 21 Jun 2023 19:05:30 +0000 Subject: [PATCH 2/7] chore(release): 0.10.1 [skip ci] --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index d37a5121..572541e7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@brightspace-ui/testing", - "version": "0.10.0", + "version": "0.10.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@brightspace-ui/testing", - "version": "0.10.0", + "version": "0.10.1", "license": "Apache-2.0", "dependencies": { "@open-wc/testing": "^3", diff --git a/package.json b/package.json index 24e141c1..da8d08cd 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "@brightspace-ui/testing", "description": "Utilities for testing front-end components and applications", "type": "module", - "version": "0.10.0", + "version": "0.10.1", "repository": "https://github.com/BrightspaceUI/testing.git", "scripts": { "lint": "eslint . --ext .js", From f98d6af71a1d891278fb1964a8a3dd9cbb8b1b8d Mon Sep 17 00:00:00 2001 From: Stacey Van Herk <13419300+svanherk@users.noreply.github.com> Date: Wed, 21 Jun 2023 17:06:23 -0400 Subject: [PATCH 3/7] fix: Fix Debug mode for Windows (#37) * Fix debug mode on Windows * Fix alphabetizing of params --- src/server/headed-mode-plugin.js | 2 +- src/server/wtr-config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/headed-mode-plugin.js b/src/server/headed-mode-plugin.js index 3479fe9f..cc4c757d 100644 --- a/src/server/headed-mode-plugin.js +++ b/src/server/headed-mode-plugin.js @@ -2,7 +2,7 @@ import { globSync } from 'glob'; export function headedMode({ manual, watch, pattern }) { - const files = globSync(pattern, { ignore: 'node_modules/**' }); + const files = globSync(pattern, { ignore: 'node_modules/**', posix: true }); return { name: 'brightspace-headed-mode', diff --git a/src/server/wtr-config.js b/src/server/wtr-config.js index c08dc7fe..00f44e67 100644 --- a/src/server/wtr-config.js +++ b/src/server/wtr-config.js @@ -13,10 +13,10 @@ const optionDefinitions = [ { name: 'watch', type: Boolean }, // custom options { name: 'chromium', type: Boolean }, + { name: 'filter', alias: 'f', type: String, multiple: true }, { name: 'firefox', type: Boolean }, { name: 'golden', type: Boolean }, { name: 'grep', alias: 'g', type: String }, - { name: 'filter', alias: 'f', type: String, multiple: true }, { name: 'timeout', type: Number }, { name: 'webkit', type: Boolean }, ]; From 965e8e1df6c290d1ef2d95fe4200bd81bf4156fe Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Wed, 21 Jun 2023 21:07:15 +0000 Subject: [PATCH 4/7] chore(release): 0.10.2 [skip ci] --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 572541e7..7e14fe88 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@brightspace-ui/testing", - "version": "0.10.1", + "version": "0.10.2", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@brightspace-ui/testing", - "version": "0.10.1", + "version": "0.10.2", "license": "Apache-2.0", "dependencies": { "@open-wc/testing": "^3", diff --git a/package.json b/package.json index da8d08cd..c8833518 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "@brightspace-ui/testing", "description": "Utilities for testing front-end components and applications", "type": "module", - "version": "0.10.1", + "version": "0.10.2", "repository": "https://github.com/BrightspaceUI/testing.git", "scripts": { "lint": "eslint . --ext .js", From 972645689c5800e94539c55d84462534de96ae71 Mon Sep 17 00:00:00 2001 From: "d2l-github-action-tokens[bot]" <78449032+d2l-github-action-tokens[bot]@users.noreply.github.com> Date: Thu, 22 Jun 2023 12:45:14 +0000 Subject: [PATCH 5/7] Auto Update Dependencies (#38) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- package-lock.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7e14fe88..a5b1d288 100644 --- a/package-lock.json +++ b/package-lock.json @@ -2659,9 +2659,9 @@ "integrity": "sha512-WMwm9LhRUo+WUaRN+vRuETqG89IgZphVSNkdFgeb6sS/E4OrDIN7t48CAewSHXc6C8lefD8KKfr5vY61brQlow==" }, "node_modules/electron-to-chromium": { - "version": "1.4.435", - "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.435.tgz", - "integrity": "sha512-B0CBWVFhvoQCW/XtjRzgrmqcgVWg6RXOEM/dK59+wFV93BFGR6AeNKc4OyhM+T3IhJaOOG8o/V+33Y2mwJWtzw==", + "version": "1.4.437", + "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.437.tgz", + "integrity": "sha512-ZFekRuBOHUXp21wrR5lshT6pZa/KmjkhKBAtmZz4NN5sCWlHOk3kdhiwFINrDBsRLX6FjyBAb1TRN+KBeNlyzQ==", "dev": true, "peer": true }, @@ -3642,9 +3642,9 @@ } }, "node_modules/glob": { - "version": "10.2.7", - "resolved": "https://registry.npmjs.org/glob/-/glob-10.2.7.tgz", - "integrity": "sha512-jTKehsravOJo8IJxUGfZILnkvVJM/MOfHRs8QcXolVef2zNI9Tqyy5+SeuOAZd3upViEZQLyFpQhYiHLrMUNmA==", + "version": "10.3.0", + "resolved": "https://registry.npmjs.org/glob/-/glob-10.3.0.tgz", + "integrity": "sha512-AQ1/SB9HH0yCx1jXAT4vmCbTOPe5RQ+kCurjbel5xSCGhebumUv+GJZfa1rEqor3XIViqwSEmlkZCQD43RWrBg==", "dependencies": { "foreground-child": "^3.1.0", "jackspeak": "^2.0.3", From 38de7a28006ab215cbb75905d5dc25c5c6d23fb5 Mon Sep 17 00:00:00 2001 From: Dave Lockhart Date: Thu, 22 Jun 2023 09:39:28 -0400 Subject: [PATCH 6/7] feat: move elem argument first (#39) --- src/browser/commands.js | 2 +- test/browser/commands.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/browser/commands.js b/src/browser/commands.js index c54aaa8f..3e65c4ba 100644 --- a/src/browser/commands.js +++ b/src/browser/commands.js @@ -37,7 +37,7 @@ export async function sendKeys(action, keys) { await cmdSendKeys(val); } -export async function sendKeysElem(action, keys, elem) { +export async function sendKeysElem(elem, action, keys) { if (elem) { await focusElem(elem); } diff --git a/test/browser/commands.test.js b/test/browser/commands.test.js index 104321dd..7a3708a2 100644 --- a/test/browser/commands.test.js +++ b/test/browser/commands.test.js @@ -58,7 +58,7 @@ describe('commands', () => { }); it('should send keys to element', async() => { - await sendKeysElem('type', 'Hello', elem); + await sendKeysElem(elem, 'type', 'Hello'); expect(elem.value).to.equal('Hello'); }); From 6bba8c2da1a3e21f69d01b3ecfe01e355f936c8e Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Thu, 22 Jun 2023 13:40:29 +0000 Subject: [PATCH 7/7] chore(release): 0.11.0 [skip ci] --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index a5b1d288..c05eeaea 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@brightspace-ui/testing", - "version": "0.10.2", + "version": "0.11.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@brightspace-ui/testing", - "version": "0.10.2", + "version": "0.11.0", "license": "Apache-2.0", "dependencies": { "@open-wc/testing": "^3", diff --git a/package.json b/package.json index c8833518..aa9c19ad 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "@brightspace-ui/testing", "description": "Utilities for testing front-end components and applications", "type": "module", - "version": "0.10.2", + "version": "0.11.0", "repository": "https://github.com/BrightspaceUI/testing.git", "scripts": { "lint": "eslint . --ext .js",