Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2l-tabs: Scrolling enhancements #3404

Open
TristanDevos opened this issue Mar 15, 2023 · 2 comments
Open

d2l-tabs: Scrolling enhancements #3404

TristanDevos opened this issue Mar 15, 2023 · 2 comments

Comments

@TristanDevos
Copy link

  1. It would be nice if the tabs component would automatically scroll to take advantage of the full width its given when the screen resizes.

Daylight:

chrome_45BfvC16TQ

Consistent-Evaluation (using the Primary-Secondary template)

chrome_dXg9r4egBB

  1. Might be nice and intuitive to allow swiping across tabs on mobile instead of only having the left and right arrow buttons.

Example use case in Consistent-Evaluation

chrome_I5NECYyv2k

@dbatiste
Copy link
Contributor

dbatiste commented Mar 15, 2023

Yeah these are great suggestions. If these are improvements that are required for your tool, my recommendation is to reach out in #wc-tabs in Slack and we can loop in Nathan and Asja to prioritize.

I know the swipe functionality was discussed when this was originally built. To some extent it didn't fall into scope, but also, it was not going to be able to mimics browsers normal behaviour for swipe/flicking/acceleration (due to the virtual scroll implementation), at least not without a heavy lift.

@TristanDevos
Copy link
Author

If these are improvements that are required for your tool, my recommendation is to reach out in #wc-tabs in Slack and we can loop in Nathan and Asja to prioritize.

Thanks Dave. These aren't required for CE currently, they're more 'nice to haves'. No need to prioritize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants