Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListItemCheckboxMixin causes ARIA attribute cannot be used: aria-labelledby #1303

Open
Vitalii-Misechko opened this issue Apr 29, 2021 · 1 comment
Open

ListItemCheckboxMixin causes ARIA attribute cannot be used: aria-labelledby #1303

Vitalii-Misechko opened this issue Apr 29, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Vitalii-Misechko
Copy link
Contributor

Basically, axe-core 4.2.0 code states that

// aria-label and aria-labelledy are not allowed on elements
// without roles, but if the element has text content then
// we will return undefined as a screen reader will read
// the text content

It seems that _renderCheckboxAction function renders a label that does not have an ARIA role according to getRoles of axe-core.

JFYI @bemailloux @johngwilkinson
@Vitalii-Misechko Vitalii-Misechko added the bug Something isn't working label Apr 29, 2021
@Vitalii-Misechko
Copy link
Contributor Author

The issue can be reproduced using this test https://github.com/Brightspace/insights-engagement-dashboard/blob/0b276d36217ba7cd52f3e0e093125a73d3dd46b2/test/components/card-selection-list.test.js#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vitalii-Misechko