Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file:// attachment links not stored like http:// and https:// #5321

Open
haydenkwelsh opened this issue Nov 14, 2024 · 1 comment
Open

file:// attachment links not stored like http:// and https:// #5321

haydenkwelsh opened this issue Nov 14, 2024 · 1 comment
Labels

Comments

@haydenkwelsh
Copy link

haydenkwelsh commented Nov 14, 2024

Describe the Bug

When a http:// or https:// attachment link is created ...
image
... it will be stored by Bookstack ...
image
... which makes updating a link used multiple times in a document easy, as you only have to change it once in the "Attachments" side menu.

On the other hand, when a file:// attachment link is created ...
image
... it is NOT stored by Bookstack ...
image
... which makes updating a link used multiple times in a document very tedious.

Apologies if this is behaviour has a sound reason behind it, but it seems like Bookstack storing all attachment links would be helpful and provide consistency.

Steps to Reproduce

  1. Create an Attachment link starting with http:// or https://.
  2. Insert the Attachment link.
  3. View the (Bookstack-stored) URL by clicking the newly-inserted link and the left-most chain (⛓) icon:
    image
  4. Repeat steps 1-3 for a link starting with file://.

Expected Behaviour

All links (starting with http://, https://, file://, etc) added to a document's "Attachments" will be stored by Bookstack for ease of future link editing. Some may not be stored due to potential validation checks, but such failures should be indicated to the end user in the form of a pop-up or other sensible method.

Screenshots or Additional Context

See screenshots taken above.

This is somewhat related to these other issues:

Browser Details

n/a

Exact BookStack Version

v24.02

@ssddanbrown
Copy link
Member

Hi @haydenkwelsh,
From what I remember, we show/expose non http(s) links directly since we can't reliable be sure that other links types are going to function via the dynamic redirect mechanism that's in place for http(s) links.
Especially so with file links which are often blocked in various ways in modern browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants