Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for STORAGE_S3_TOKEN #5302

Closed
wants to merge 1 commit into from

Conversation

vlaborie
Copy link

@vlaborie vlaborie commented Nov 1, 2024

Hello,

To resolve #5273 and support temporary S3 credentials generated by STS.

@ssddanbrown
Copy link
Member

Thanks for offering this, but I'm not keen on expanding our support for S3 specific options, at least without some significant proven need/demand, whereas this seems to be desired for a one-off scenario specific context.

If it helps, you can override our config files using our logical theme system, so you could effectively apply the same config value to your instance at runtime using the follow functions.php theme file:

<?php

use BookStack\Facades\Theme;
use BookStack\Theming\ThemeEvents;

Theme::listen(ThemeEvents::APP_BOOT, function () {
    config()->set('filesystems.disks.s3.token', 'mytokenvaluehere');
});

@ssddanbrown ssddanbrown closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support for STORAGE_S3_TOKEN
2 participants