-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy shelf permission to a book when the book is created directly within a shelf #1596
Comments
Hi @mattstanyon-tall, Where I detail the complexity in Shelf -> Book auto-permission inheritance. |
Hi @ssddanbrown I reviewed this, however, I was wondering if this could be set on initial creation only, which is slightly different from the previous request. Understanding that once a book has been created it could then be a member of various shelves, etc. However, if you select Shelf > Create a new book, my request is whether this new book could inherit/copy the permissions from the Shelf. Post creation, the permissions on the books might change, and the book might become a member of different shelves etc. Perhaps we are using the product in a different way from intended, but, if most books are created from within a shelf, rather than added to shelves later, this seems logical (to me!). I haven't fully got my head around how the permissions on Shelves work in regard to items within that shelf - perhaps this is causing some confusion, in which case, my apologies. As we push BookStack into the org here, this is one of the items which has come up from various different user groups. Perhaps the command-line tool you mentioned would resolve this, this is just a slightly different use-case/approach. Finally, the remaining feedback is fantastic. You have a great product, so thank you for the time and effort invested. |
Thanks for the positive feedback. I get what you mean and can see how this would be helpful. I'll update the issue title to reflect the core request. |
|
Please add an option to copy permissions during book creation via shelf context. Or enable an inheritance option ;) |
Hi, I'd like to add that this would be very interesting from a security perspective as well - currently, if someone creates a new book, it is temporarily publicly visible until the owner goes into the Permissions menu and clicks the copy button. |
Hi |
Full ACK to @tacerus and @Ronald4300. We're currently forced to heavily restrict the shelf/book creation, as we had a lot of permissions problems in the past. This is a real pity, as we are generally are very happy with Bookstack and especially appreciate its simplicity and ease of use. So, either having a checkbox |
Here is an easy Logical Theme solution: #4411 |
This is 100% needed. It looks like the same sort of issue from another post I found when researching this problem: Why allow a user to create books but then disallow them to be able to access it once it's created (assuming they also have edit permission). It seems really really really limiting to allow a user to create a book but they can't see it once they create it. It really destroys self-sufficiency. |
Would it be possible to have new books inherit the permissions of the shelf they are created under (assuming they are indeed created under a shelf)?
My understanding is the permissions set on shelves do not propagate unless you use the copy permissions, therefore I don't think this would cause a conflict, but it would mean there is one less step many users need to perform, by default.
The text was updated successfully, but these errors were encountered: