Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refund page: Split up into two sections (UTXO/EVM) #747

Open
kilrau opened this issue Nov 25, 2024 · 3 comments
Open

Refund page: Split up into two sections (UTXO/EVM) #747

kilrau opened this issue Nov 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working P1 RSK

Comments

@kilrau
Copy link
Member

kilrau commented Nov 25, 2024

  1. In the initial state of our refund page, the "connect wallet" button exists to be able to connect a Rootstock wallet and scan for refundable swaps.
    image
    BUT that's just super confusing for users who never used or don't plan to use Rootstock or are not thinking about Rootstock in this moment. It feels like the "continue" button - that I have to connect a wallet to do a Liquid refund.
    image

Also it is confusing for users that don't know that a Rootstock wallet can be scanned for refundable swaps. We should make it clear that refund section has two parts: file upload is for swaps originating from UTXO chains like Liquid, the wallet connect button for swaps originating from EVM chains like Rootstock. I propose to use the following descriptions headlining each:
For refunds originating from UTXO chains like Liquid, Upload your refund file and reclaim your locked funds.
For refunds originating from EVM chains like Rootstock, connect your wallet below to scan for refundable swaps.

Maybe with a separator line in between them.

  1. When a wallet is connected, fully scanned and doesn't have refundable swaps we should say that in a button below No refundable swaps found otherwise the button should say Refund Swap to open the swap for refund. I had support cases where users just didn't understand to enter the displayed swap via the View button. Maybe we should call the View button Refund in this state.
    image

Yes, this creates two entries into refunding a swap: one big button on the bottom and one small View/Refund button for each swap in the list and that is wanted because there might be multiple refundable swaps found in a rootstock wallet the same way utxo chains can have multiple refundable swaps in local storage and users can enter them individually by pressing View/Refund. The big Refund button below just always enters the first refundable swap and exists for the sake of users not missing the button in the 99% case where there is only one refundable swap.

  1. If a non-Rootstock refund file is uploaded this is the state. I would completely remove the rootstock part for this state.
    image

  2. The same way I would remove the Refund file upload section when a refundable rootstock swap is displayed.

So /refund offers two ways to start out: utxo and evm refund but when one is active, it only shows one.

@kilrau kilrau added the enhancement New feature or request label Nov 25, 2024
@kilrau kilrau added bug Something isn't working P1 RSK and removed enhancement New feature or request labels Nov 25, 2024
@kilrau kilrau changed the title Roostock refunds missing refund button on /refund Refund page: Split up into two sections (UTXO/EVM) Nov 26, 2024
@jackstar12
Copy link
Member

I propose to use the following descriptions headlining each:
For refunds originating from UTXO chains like Liquid, Upload your refund file and reclaim your locked funds.
For refunds originating from EVM chains like Rootstock, connect your wallet below to scan for refundable swaps.

I think these are too complicated.

We could go for a tab / pills like ui where one either gets the choice

  • "Bitcoin like" - not sure about that naming
  • "Rootstock" - no need to throw the word EVM in here since its the only one

looking like:
image

@michael1011
Copy link
Member

Agreed. If you need to explain an UI you did it wrong

@kilrau
Copy link
Member Author

kilrau commented Nov 26, 2024

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 RSK
Projects
None yet
Development

No branches or pull requests

3 participants