Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show exact refund amount to be received #572

Open
kilrau opened this issue May 1, 2024 · 2 comments
Open

Show exact refund amount to be received #572

kilrau opened this issue May 1, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@kilrau
Copy link
Member

kilrau commented May 1, 2024

IMG_20240502_001254
@kilrau kilrau changed the title Show final refund amount Show exact refund amount to be received May 2, 2024
@kilrau kilrau added the enhancement New feature or request label May 2, 2024
@michael1011
Copy link
Member

Just to make sure everyone is aware of the side effects: showing exact amounts to be refunded means fetching the fee rate when a swap to refund is selected. That fee rate cannot change (else the amount changes) as long as the page stays open. And when switching between swaps to refund, that fee rate is fetched again and might change

@kilrau
Copy link
Member Author

kilrau commented May 30, 2024 •
edited
Loading

Gotcha. Can we reuse the logic of the regular swap box network fee rate changes?

@kilrau kilrau unassigned dni Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dni @michael1011 @kilrau