Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spillover matrix visualization issue #22

Closed
PingjunChen opened this issue Jun 29, 2022 · 2 comments
Closed

Spillover matrix visualization issue #22

PingjunChen opened this issue Jun 29, 2022 · 2 comments

Comments

@PingjunChen
Copy link

PingjunChen commented Jun 29, 2022

Hey,

I followed this spillover correction tutorial to conduct the spillover analysis on our data. The heatmap in section 6.1.4 still contains all the antibodies from 113 to 176, while section 6.1.5 showcases the spillover matrix missed some antibodies from 172 to 176. After carefully checking the code, I found out some of them are masked out by the is_bc, and I set rowData(sce)$is_bc <- TRUE after "apply the estimated cutoffs" in section 6.1.4, then the spillover matrix contains all antibodies. Are these antibodies (172 to 176 in the demo figure) missing in the spillover matrix performed on purpose? and does my way of taking all antibodies back reasonable or not? since I'm not fully understand the underlying principles yet, and I assume we need to have all the antibodies covered in the generated spillover matrix when performing visualization, though I noticed the saved CSV file in section 6.1.6 containing all antibodies' information.

@nilseling
Copy link
Contributor

Hi @PingjunChen
this is a known issue in CATALYST (see here) and still needs to be fixed. Since it's only part of the visualization I'm not so fussed about it at the moment but will come back to trying to circumvent the issue at some point. If your fix works for you then it's great!

@nilseling
Copy link
Contributor

Closing as this is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants