Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optimization] Research and configure the minifier to inline more values #92

Open
Bnaya opened this issue May 29, 2020 · 1 comment
Open

[optimization] Research and configure the minifier to inline more values #92

Bnaya opened this issue May 29, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Bnaya
Copy link
Owner

Bnaya commented May 29, 2020 •
edited
Loading

Notes:
We are using terser.
There are static/const values as:
l.NUMBER, l.BIGINT_POSITIVE, l.BIGINT_NEGATIVE, l.STRING;
Or Uint32Array.BYTES_PER_ELEMENT that although statically known, not are not beaning inlined by terser.
To see the the minified code:
https://unpkg.com/@bnaya/[email protected]/dist/objectbuffer.esm.js
And also run yarn build and look at the dist folder

See if https://github.com/terser/terser#annotations can help
@Bnaya Bnaya added the good first issue Good for newcomers label May 29, 2020
@Bnaya Bnaya mentioned this issue May 29, 2020
Open
11 tasks
@Bnaya Bnaya added the help wanted Extra attention is needed label May 29, 2020
@Bnaya Bnaya changed the title [optimization] Research and configure the minifyer to inline more values [optimization] Research and configure the minifier to inline more values Jun 29, 2020
@Bnaya
Copy link
Owner Author

Bnaya commented Sep 17, 2020

See also terser/terser#828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bnaya