Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make team dynamics robust #16

Open
lordshashank opened this issue Jan 17, 2024 · 2 comments
Open

Make team dynamics robust #16

lordshashank opened this issue Jan 17, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers smart contracts Issue related to smart contracts

Comments

@lordshashank
Copy link
Collaborator

lordshashank commented Jan 17, 2024

Currently a builder can only signup in one team through initializeTeam function and can't change the team.

Implement a changeTeam function along with making required changes in other functions that enable builders to change team after registering in one.
ALso implement the following checks-

  • NotInTeam modifier
  • UniqueTeamName modifier
@lordshashank lordshashank added enhancement New feature or request good first issue Good for newcomers smart contracts Issue related to smart contracts labels Jan 17, 2024
@yomanthunder
Copy link
Contributor

Re-impliment initializeTeam

Issues with Present initializeTeam Function:

  • The person initializing the team has way too much power as they can add other builders without their consent.
  • There isn't a function to change teams.

Proposed Solution:

  • The person initializing the team will create a team with only themselves in it.
  • We generate a unique code for each team created (which can only be accessed by team members).
  • People can join a team based on the team code.

This process makes the code less complicated and easily customizable for people who want to join, leave, or change teams based on their own consent.
I will make the pr today after your conformation @lordshashank

@lordshashank
Copy link
Collaborator Author

lordshashank commented Feb 11, 2024

Team code would not work, everything is publicly accessible in blockchain. Just implement changeTeam function compatible with code. we would have to block team changing after some time into the hackathon so as to avoid malicious behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers smart contracts Issue related to smart contracts
Projects
None yet
Development

No branches or pull requests

2 participants