Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require hidden templates to be valid #115

Open
Blesmol opened this issue Oct 7, 2020 · 0 comments
Open

Do not require hidden templates to be valid #115

Blesmol opened this issue Oct 7, 2020 · 0 comments
Labels
enhancement New feature or request target: template creator Issue is relevant for people creating chronicle templates

Comments

@Blesmol
Copy link
Owner

Blesmol commented Oct 7, 2020

Hidden templates were added as additional structural layer, mainly for the scenario where there the major sheet layout is changed between seasons, but where a 1:1 relation between layout and season still does not make sense. For example, PFS2 season 01 will be using layout 1, PFS2 seasons 02 and following will be using layout 2 (according to current knowledge).

But even if two seasons are using the same major layout, it may be that there are slight differences between the layouts for these seasons. Overcoming these differences is already possible by configuring the layout.yml to take the respective values from presets entries and then providing the concrete values in the seasons main yml files.

For this scenario it would not be required that the hidden layout template is valid, can be resolved or can be used to generate anything. On the contrary: If someone would then inherit such a hidden layout.yml file, she/he would be presented with error messages like Cannot find presets "downtime_number_of_lines" to provide the missing values for that concrete season.

Thus it would make sense to not perform the isValid() and resolve() actions for hidden templates and return an error message if a hidden template is used to generate output.

@Blesmol Blesmol added enhancement New feature or request target: template creator Issue is relevant for people creating chronicle templates labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request target: template creator Issue is relevant for people creating chronicle templates
Projects
None yet
Development

No branches or pull requests

1 participant