-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design specs for the desktop top bar component #57
Comments
Let me work on this one |
Here's what I've done so far - Figma file I think I covered them all, next steps would be to do wallet selector and it's states. I added "Yellow" (light/dark) color to use for node indicator. I also used layout for the component and it's responsive (although for condesed state I had to change autolayout settings). |
Did some updates. Two layouts of wallet selector/balance and 2 types of color states. But I just realised the one with grey box @yashrajd proposed can be also nice, I can try this one as well. You can try the prototype here I also added "pressed" state. Another idea for hover could perhaps be similar but darker |
Prototype's cool & very helpful @stackingsaunter. I'm conflicted about Hover state: grey box will maintain consistency with existing behaviour (like Back button already implemented) but orange is fine too. I'm agnostic about a Pressed state, but if implemented I prefer it as implemented in the prototype (orange + grey box, which makes sense since you need to hover before pressing) instead of the white in grey box as in your image above. So here's my view (for dark mode) so far:
For wallet selector/balance, I prefer white labels instead of grey. Unsure about icon since it means we have to provide options + extra UI to choose but perhaps we could do it in the future. Emoji set might be an easy way to go. |
Thank you for all the work on this, makes it super easy to compare options. I prefer the more subtle one with light grey text. It uses our color palette in a nicer way, IMHO. Having a very light transition duration of 100-150ms will also make it just a little bit nicer. For toggling between balance display, we could also rely on the shift key. So shift-click to switch between full bitcoin (0.01 000 000), trimmed bitcoin (0.01), sats (10,000,000), and maybe even hidden balance. That would be in addition to having a toggle elsewhere, like the application menu bar and settings. I looked into the wallet icon a bit more. It would be cool if those could represent different types, so here are some ideas. If we have a good hover state, maybe we don't need the small arrow to indicate the switcher? |
For mobile, I'd keep send and receive as tabs since those are primary options (compared to block clock and settings) and tabs are easy to reach on mobile. It also solves the privacy issue of exposing your balance when you want to just do a quick send/receive. |
Components are ready to review - Figma file Current mobile design oscillates around those 4 ideas. More work to be done here |
@GBKS did you end up deciding on mobile direction while I was gone? |
Here's the latest (if I remember correctly. It might be nice to put together a web prototype for some of this stuff, so we can quickly feel it out and iterate. |
After some thought, I propose this screen as main mobile nav: My reasoning:
Alternitavely, wallet selector could be wider for easier selection |
I think this can be closed, as we agreed on the layout and you @GBKS updated the main file already. This is the mobile design we ended up with: |
Looks like I need to update a few minor things on the design docs still. Also spoke with @johnny9 yesterday about the wallet list. He's going to look into what information we have about closed wallets. Might be easiest for now to just design three options where we just have the name, name + type, and name + type + balance, and then use whichever one we can make work technically. |
It looks like you only know the name of the wallet folder if the wallet is closed. When the wallet is open you know all of the other values. From my understanding, I think the UX can be modified for the new UI and attempt to load the wallets for these values unless they were previously closed. If they are closed, persist that in the settings. Regardless, we do need to have a clear "closed" state for the wallet selector. |
In yesterday's call, we reviewed the current draft of the updated nav structure for when we have all the wallet features. An important element of this is the top bar on the desktop. Let's spec out all the different states in detail.
From the current design draft:
Older designs which show a lot of different states, but have a dedicated wallet page which we don't want anymore.
Jarol had also asked us to mock-up the hover, selected, disabled, focus and any other states needed. Those should be pretty straightforward now since we have our standard treatments defined.
The text was updated successfully, but these errors were encountered: