From 166dd8ee88d93954ecbaf6ab3cba56f9b436ff86 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartosz=20Wojda=C5=82owicz?=
<50419023+BartoszWojdalowicz@users.noreply.github.com>
Date: Tue, 14 May 2024 08:12:14 +0200
Subject: [PATCH] OP-273 - fix sylius 1.12 integration
* OP-273 - fix not existing service on 1.12. Fix sylius version in gh actions.
* OP-273 - fix sylius version in gh actions.
* OP-273 - fix tests on 1.12
---
.github/workflows/build.yml | 4 +++-
.../shop/site_wide_searching_products.feature | 18 +++++++++---------
src/Resources/config/services/transformer.xml | 2 +-
.../Resources/services/contexts/setup.xml | 2 +-
4 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 95be71f2..d7b3eb6f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -23,7 +23,7 @@ jobs:
matrix:
php: [ "8.1", "8.2", "8.3" ]
symfony: [ "^5.4", "^6.0" ]
- sylius: [ "^1.12", "^1.13" ]
+ sylius: [ "~1.12.0", "~1.13.0" ]
node: [ "18.x", "20.x" ]
mysql: [ "5.7", "8.0" ]
env:
@@ -176,10 +176,12 @@ jobs:
-
name: Run Behat
+ if: ${{ matrix.sylius != '~1.13.0' }}
run: vendor/bin/behat --colors --strict -vvv --no-interaction --tags '~@sylius113' || vendor/bin/behat --colors --strict -vvv --no-interaction --rerun --tags '~@sylius113'
-
name: Run Behat
+ if: ${{ matrix.sylius == '~1.13.0' }}
run: vendor/bin/behat --colors --strict -vvv --no-interaction --tags '~@sylius112' || vendor/bin/behat --colors --strict -vvv --no-interaction --rerun --tags '~@sylius112'
diff --git a/features/shop/site_wide_searching_products.feature b/features/shop/site_wide_searching_products.feature
index fe712590..41dd6cc3 100644
--- a/features/shop/site_wide_searching_products.feature
+++ b/features/shop/site_wide_searching_products.feature
@@ -11,34 +11,34 @@ Feature: Site-wide products search
And the store has a select product attribute "Car Type" with values "Cabrio" and "SUV"
And the store has a select product attribute "Motorbike Type" with values "Enduro" and "Naked"
And there is a product named "BMW Z4" in the store
- And this product's price is "$42,670.00"
+ And this product's price is "$42670"
And this product has select attribute "Car Type" with value "Cabrio"
And this product has a text attribute "Color" with value "Red"
And this product has option "Supply" with values "Gasoline" and "Diesel"
- And this product is available in "Gasoline" supply priced at "$42,670.00"
- And this product is available in "Diesel" supply priced at "$45,670.00"
+ And this product is available in "Gasoline" supply priced at "$42670"
+ And this product is available in "Diesel" supply priced at "$45670"
And this product belongs to "Cars"
And there is a product named "Volvo XC90" in the store
- And this product's price is "$64,505.80"
+ And this product's price is "$64505.80"
And this product has select attribute "Car Type" with value "SUV"
And this product has a text attribute "Color" with value "Black"
And this product belongs to "Cars"
And there is a product named "BMW 5 Series" in the store
- And this product's price is "$52,070.00"
+ And this product's price is "$52070"
And this product has select attribute "Car Type" with value "Cabrio"
And this product has a text attribute "Color" with value "Red"
And this product belongs to "Cars"
And there is a product named "Lamborghini Aventador" in the store
- And this product's price is "$450,000.00"
+ And this product's price is "$450000"
And this product has a text attribute "Color" with value "Yellow"
And this product belongs to "Cars"
And there is a product named "BMW GS" in the store
- And this product's price is "$18,070.00"
+ And this product's price is "$18070"
And this product has select attribute "Motorbike Type" with value "Enduro"
And this product has a text attribute "Color" with value "Grey"
And this product belongs to "Motorbikes"
And there is a product named "Ducati Monster" in the store
- And this product's price is "$14,995.00"
+ And this product's price is "$14995"
And this product has select attribute "Motorbike Type" with value "Naked"
And this product has a text attribute "Color" with value "Black"
And this product's short description is:
@@ -49,7 +49,7 @@ Feature: Site-wide products search
And there is a product named "Honda Africa Twin" in the store
And this product has select attribute "Motorbike Type" with value "Enduro"
And this product has a text attribute "Color" with value "Green & White"
- And this product's price is "$13,490.00"
+ And this product's price is "$13490"
And this product's description is:
"""
This is the Honda Africa Twin which is like the BMW GS but from Honda.
diff --git a/src/Resources/config/services/transformer.xml b/src/Resources/config/services/transformer.xml
index bf5a3338..0f91bfc7 100644
--- a/src/Resources/config/services/transformer.xml
+++ b/src/Resources/config/services/transformer.xml
@@ -5,7 +5,7 @@
-
+
diff --git a/tests/Behat/Resources/services/contexts/setup.xml b/tests/Behat/Resources/services/contexts/setup.xml
index da958078..5bbd17ca 100644
--- a/tests/Behat/Resources/services/contexts/setup.xml
+++ b/tests/Behat/Resources/services/contexts/setup.xml
@@ -12,7 +12,7 @@
-
+